Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch Migrator #226

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This feedstock is being rebuilt as part of the aarch64/ppc64le migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM migrators first at @conda-forge/arm-arch.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8379759106, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libtorch' output doesn't have any tests.

@jeongseok-meta
Copy link
Contributor

I wonder if it would be possible to fix and merge this, please? Thanks in advance!

@jakirkham
Copy link
Member

jakirkham commented Aug 29, 2024

Hey Jeongseok, could you share a little bit more what you are looking for?

To provide a bit more clarity, this feedstock is already building for Linux ARM (and Linux ARM for CUDA 12). For the most recent work, please see the merged PR: #224

So at this point the bot is making cosmetic changes to the recipe

The only targets not covered at this point are:

  • Linux PPC
  • Linux ARM for CUDA 11.8 (note CUDA 12 is already included)
  • Windows

@jeongseok-meta
Copy link
Contributor

Thank you for the context. I wish to have linux_ppc64le support as part of this change.

@jakirkham
Copy link
Member

Thanks for the info! 🙏

So we can ask the bot to regenerate this PR, which would resolve the conflicts. Likely the skips in the recipe need updates to enable linux_ppc64le

A better approach may be to start a new PR. It would involve adding linux_ppc64le (analogous to how linux_aarch64 is already done below)

build_platform:
linux_aarch64: linux_64
osx_arm64: osx_64

Making any updates to the recipes skips to ensure linux_ppc64le is covered

skip: true # [win]
skip: true # [cuda_compiler_version != "None" and linux64 and blas_impl != "mkl"]
# 2024/04 This build seems to fail due to disk space on the CIs
# We can potentially re-enable it at a later time
skip: true # [cuda_compiler_version == "11.8" and aarch64]

Then re-rendering

At that point we could see how things go on CI. If all works, great it can be merged. If not, then you would be able to iterate a bit

Would you be interested in giving that a try? 🙂

@jeongseok-meta
Copy link
Contributor

Whoa, thank you for the detailed instructions. Let me give it a try!

@jakirkham
Copy link
Member

Thanks Jeongseok! 🙏

Continued in PR: #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants