Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run new conda_forge lints #98

Merged
merged 3 commits into from
Sep 10, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conda-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
conda-smithy
conda-smithy>=2.4
tornado
pygithub
nose
Expand Down
2 changes: 1 addition & 1 deletion conda_forge_webservices/linting.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def compute_lint_message(repo_owner, repo_name, pr_id, ignore_base=False):
rel_path = os.path.relpath(recipe_dir, tmp_dir)
rel_pr_recipes.append(rel_path)
try:
lints = conda_smithy.lint_recipe.main(recipe_dir)
lints = conda_smithy.lint_recipe.main(recipe_dir, conda_forge=True)
except Exception as err:
print('ERROR:', err)
lints = ['Failed to even lint the recipe (might be a conda-smithy bug) :cry:']
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,11 @@ def test_bad_recipe(self):
* The home item is expected in the about section.
* The license item is expected in the about section.
* The summary item is expected in the about section.
* The recipe could do with some maintainers listed in the `extra/recipe-maintainers` section.
* The recipe must have some tests.
* The recipe must have a `build/number` section.
* There should be one empty line at the end of the file.
* There are 2 too many lines. There should be one empty line at the end of the file.
* Feedstock with the same name exists in conda-forge
* Recipe maintainer "support" does not exist
""")

lint = compute_lint_message('conda-forge', 'conda-forge-webservices', 17)
Expand Down