Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run new conda_forge lints #98

Merged
merged 3 commits into from
Sep 10, 2017
Merged

Run new conda_forge lints #98

merged 3 commits into from
Sep 10, 2017

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Sep 6, 2017

No description provided.

@jakirkham
Copy link
Member

Pushed this to the repo for you so that it can be tested (requires a GitHub token for some of the tests).

@isuruf
Copy link
Member Author

isuruf commented Sep 6, 2017

I'm sorry, how do I test it?

@jakirkham
Copy link
Member

By pushing the branch to this repo directly. Have just added you to conda-forge/conda-forge-webservices so that you can do this as needed.

@jakirkham
Copy link
Member

Should add that I pushed these changes to the branch isuruf/lint on this repo.

@isuruf
Copy link
Member Author

isuruf commented Sep 6, 2017

And if I add a recipe to the root, it would automatically check the recipe?

@jakirkham
Copy link
Member

It searches for anything that looks like a recipe (has a meta.yaml). We put these in PRs like this one. Though it might be worth building off of existing PRs to cutdown on the number of these we create (if possible). There are checks for the message that one gets, which are the most useful. Though we also have integration tests that comment on the PR if needed.

@isuruf
Copy link
Member Author

isuruf commented Sep 7, 2017

@jakirkham, can you explain what I have to do? Btw, these lints are checked in conda-smithy.

@jakirkham
Copy link
Member

So if you have already changed the bad recipe, would update the message in the bad recipe test.

Were there any things that we weren't testing in conda-smithy that would require a token? If so, this is something we should try testing here.

@isuruf
Copy link
Member Author

isuruf commented Sep 7, 2017

Changed bad_recipe again to check one more lint that needed GH_TOKEN. I'll update the test

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @isuruf.

@isuruf
Copy link
Member Author

isuruf commented Sep 10, 2017

Tests pass. Merging.

@isuruf isuruf merged commit 0aaeb41 into conda-forge:master Sep 10, 2017
@isuruf
Copy link
Member Author

isuruf commented Sep 10, 2017

Does this get deployed immediately?

@jakirkham
Copy link
Member

jakirkham commented Sep 10, 2017

It is suppose to build and deploy on Heroku after you merge. Though I don't think it has. Triggering manually.

@jakirkham
Copy link
Member

Should now be deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants