Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HKG: Car Port for Genesis G70 2024 #1134

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Aug 20, 2024

Checklist

  • added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot: a6310918f9699ef5/2024-02-28--14-55-10
  • route with stock system: a6310918f9699ef5/2024-02-27--20-17-09
  • car harness used (if comma doesn't sell it, put N/A): Harness F
  • Suppress "grasp not detected" when openpilot steering and stock system's longitudinal are engaged on highways, where HDA usually is available

Thanks to the community 2024 Genesis G70 owner mayday4968 (Discord).

Requires

Superseded commaai/openpilot#31625

@github-actions github-actions bot added car related to opendbc/car/ hyundai fingerprint labels Aug 20, 2024
Copy link
Contributor

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

@sunnyhaibin
Copy link
Contributor Author

Awaiting new test route from user

@sunnyhaibin sunnyhaibin marked this pull request as draft September 27, 2024 18:33
@jyoung8607
Copy link
Collaborator

If the "grasp not detected" mitigation is compatible with all HKG with CAMERA_SCC, let's bring that out into a separate PR, and rename the safety PR to reflect what it's doing. That way we can understand it in isolation, and this will become a regular model port.

Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ hyundai stale
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants