Forward javacOptions to JMH #3578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Quafadas I think manual testing is fine for this. Presumably you are able to reproduce the original reported issue, and can use |
|
The original issue I could reproduce easily. In the issue I left a comment which was a workaround, where I copy pasted overrode the method in my local build, and that fixed the issue. I’m afraid I don’t understand the |
|
Oh I meant that you could use it for manual testing: it generates a local |
lihaoyi
pushed a commit
that referenced
this pull request
Nov 14, 2024
#3578 set out to allow passing JVM flags (for example `--add-modules=jdk.incubator.vector`) into the JVM used by the JMH plugin when trying to benchmark something in mill. That implementation kind of works, - it uses `javaCoptions` to pass to the JVM args though, which isn't very idiomatic mill. Runtime arguments are usually passed as `forkArgs`. This PR seeks to use 'forkArgs' instead of the 'javaCoptions' of the mill module. Both are a list of strings in the end, so both work, but I think this revised version more correctly follows mill nomenclature as forkedArgs rather than compiler flags. Apologies for the spamminess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this to be a solution for #3576 . However, I'm unclear how I could effectively test it. Feedback welcomed.