Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMH Plugin : This is a forkArg not a compiler option #3957

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

Quafadas
Copy link
Contributor

@Quafadas Quafadas commented Nov 14, 2024

#3578 set out to allow passing JVM flags (for example --add-modules=jdk.incubator.vector) into the JVM used by the JMH plugin when trying to benchmark something in mill.

That implementation kind of works, - it uses javaCoptions to pass to the JVM args though, which isn't very idiomatic mill. Runtime arguments are usually passed as forkArgs. This PR seeks to use 'forkArgs' instead of the 'javaCoptions' of the mill module.

Both are a list of strings in the end, so both work, but I think this revised version more correctly follows mill nomenclature as forkedArgs rather than compiler flags.

Apologies for the spamminess.

@Quafadas Quafadas changed the title This is a forkArg not a compiler option JMH Plugin : This is a forkArg not a compiler option Nov 14, 2024
@lihaoyi
Copy link
Member

lihaoyi commented Nov 14, 2024

@Quafadas could you flesh out the PR description a bit with the summary of the problem and the current status

@Quafadas
Copy link
Contributor Author

@lihaoyi done.

@lihaoyi lihaoyi merged commit 68169eb into com-lihaoyi:main Nov 14, 2024
25 checks passed
@lefou lefou added this to the 0.12.3 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants