JMH Plugin : This is a forkArg not a compiler option #3957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3578 set out to allow passing JVM flags (for example
--add-modules=jdk.incubator.vector
) into the JVM used by the JMH plugin when trying to benchmark something in mill.That implementation kind of works, - it uses
javaCoptions
to pass to the JVM args though, which isn't very idiomatic mill. Runtime arguments are usually passed asforkArgs
. This PR seeks to use 'forkArgs' instead of the 'javaCoptions' of the mill module.Both are a list of strings in the end, so both work, but I think this revised version more correctly follows mill nomenclature as forkedArgs rather than compiler flags.
Apologies for the spamminess.