Add type support to update_group_authorization #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce the complexity of the `_send_request`, and also the unify the way we are sending and receiving objects, I changed the `_send_request` method to only accept data of BaseModel type.
- The API used to return the RetryResult object. Now it returns a strong type. - It used to be called `edit_group_authorization`. I renamed to `update_group_authorization` to match the API name.
luca-cohere
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main contribution of this PR is:
edit_group_authorization. I renamed toupdate_group_authorizationto match the API name.While at this, I also changed the
_send_requestAPI to only accept objects of type BaseModel. This is to reduce its complexity, and also the unify the way we are sending and receiving objects.