Introduce more Ruff rules to improve code quality #69
Conversation
| recursive: bool = False, | ||
| ) -> List[str]: | ||
| ) -> list[str]: |
There was a problem hiding this comment.
Why are we changing this to list, i thought python preferred way is typing.List
There was a problem hiding this comment.
TL;DR - list is the recommended way starting from Python 3.9.
typing.List isn't actually the preferred. When type hinting was introduced in Python (in version 3.5), it was straight forward to support primitive types like int, float in a "natural way", i.e. using the types themselves without having to define a parallel type under the contrived typing module. However, generic types like list, dict was a bit more challenging to introduce, and hence the Python community introduced the typing model to address the challenges. But after PEP 585, which was introduced in Python 3.9, it became possible to use the types directly, i.e. list, dict, etc., without having to define a parallel type in the typing module. Hence, types like typing.Dict, typing.List, etc., are now unnecessary and they are getting deprecated and will be removed in future versions of Python; see the doc.
To ensure high code quality and capture accidental issues at build time rather the run time, I am extending the Ruff rules enabled.