Update SEU Colors Feature #1878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated SEUColorProvider to address issue with overlapping characters (SEUColorProvider now calculates Ranges based on character count rather than byte count) * Updated the SEUColorProvider code that looks for color code sequences in the source member to use a Map-based function rather than individually check against every possible color code for each byte (also updated SEUColors to provide the aforementioned function) * When a color code is found, the styling now only applies until another color code is found (or until the line ends) * Added a function to SEUColors.ts that uses a Map to check whether a given byte sequence matches any of the color sequences * When reading bytes from a source member, SEUColorProvider now uses the aforementioned Map-based function on each byte rather than individually checking it against every possible color sequence, to save time * Addressed issue with overlapping characters
|
@steph-beneschan-256 This PR is awesome. Any chance you can share the raw hex of a member that you tested this with? I'd like to be able to test this but I have no test data. |
|
Hello @worksofliam ! Here is the hex dump from the member that I used: COLORTEST.txt |
|
@steph-beneschan-256 What is the record length for that source file you used? I am going to write a test case to create that member with an example. |
|
@steph-beneschan-256 Is it possible you could get me a hex dump to that member using SQL instead? select hex(srcdta) from lib.sourcefileYou may have to create an alias to the member to read it with SQL. |
|
@steph-beneschan-256 Please see my above comment, thanks! |
|
We are removing SEU colour support in 3.0.0, so I will close this PR. Thanks for you work, nonetheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update SEU Colors Feature
Updated SEUColorProvider.ts to address issue with overlapping characters (Show SEU Colors feature is overlaying characters #1490) (the code now calculates ranges based on character count rather than byte count)
Updated the SEUColorProvider.ts code that looks for color code sequences in the source member to use a Map-based function rather than individually check against every possible color code for each byte (also updated SEUColors.ts to provide the aforementioned function)
When a color code is found, the styling now only applies until another color code is found (or until the line ends)
Added a function to SEUColors.ts that uses a Map to check whether a given byte sequence matches any of the color sequences
When reading bytes from a source member, SEUColorProvider.ts now uses the aforementioned Map-based function on each byte rather than individually checking it against every possible color sequence, to save time
Checklist
console.logs I added