Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show SEU Colors feature is overlaying characters #1490

Open
m-tyler opened this issue Aug 18, 2023 · 0 comments · May be fixed by #2192
Open

Show SEU Colors feature is overlaying characters #1490

m-tyler opened this issue Aug 18, 2023 · 0 comments · May be fixed by #2192

Comments

@m-tyler
Copy link

m-tyler commented Aug 18, 2023

Some of our source have hex code coloring that begins and ends within the comment and non space characters follow.
Example, /*x'21'/M01x'20'12345 PGxx mm/dd/YY Change text /
becomes /
#?/M01?2345 PGxx mm/dd/yy Change text */
The following characters in example (x'21', x'20', #?, ?) are actually only one character in the source, see bellow for images.

I only write this as I noticed the issue today on a member that another programmer was modifying and I was reviewing the code. I normally run a personal command, UNCOLOR, to remove these hex values from the source. So fixing this is a low priority for me but I understand this might be more meaningful to others to have fixed.

Attached is also a test member, seen below.


Context Version
Code for IBM i version 2.0.2
Visual Studio Code version 1.78.2
Operating System win32_x64
Active extensions
Binary Viewer (binary-viewer): 1.1.1
CL (vscode-clle): 1.1.1
Code Spell Checker (code-spell-checker): 2.20.5
Code for IBM i Walkthroughs (vscode-ibmi-walkthroughs): 0.3.1
Db2 for IBM i (vscode-db2i): 0.4.0
ESLint (vscode-eslint): 2.4.2
Emmet (emmet): 1.0.0
Error Lens (errorlens): 3.13.0
Excel Viewer (gc-excelviewer): 4.2.58
Git (git): 1.0.0
Git Base (git-base): 1.0.0
Git Graph (git-graph): 1.30.0
GitHub (github): 0.0.1
GitHub Authentication (github-authentication): 0.0.2
IBM i Notebooks (vscode-ibmi-notebooks): 0.0.6
JSON Language Features (json-language-features): 1.0.0
Merge Conflict (merge-conflict): 1.0.0
Microsoft Account (microsoft-authentication): 0.0.1
Node Debug Auto-attach (debug-auto-launch): 1.0.0
Overtype (overtype): 0.5.0
Partial Diff (partial-diff): 1.4.3
Project Dashboard (vscode-dashboard): 2.6.0
RPGLE (vscode-rpgle): 0.20.2
Rainbow CSV (rainbow-csv): 3.7.0
SQL Formatter VSCode (sql-formatter-vsc): 2.1.0
Text Marker (Highlighter) (text-marker): 1.11.0
Todo Tree (todo-tree): 0.0.226
TypeScript and JavaScript Language Features (typescript-language-features): 1.0.0
Version Lens (vscode-versionlens): 1.5.0
WSL: Recommender (remote-wsl-recommender): 0.0.19
XML Tools (xml): 2.5.1
classdiagram-ts (classdiagram-ts): 0.1.67
undefined (indent-rainbow): 8.3.1

Remote system
Setting Value
IBM i OS V7R5M0
Tech Refresh 2
CCSID 37
SQL Enabled
Source dates Enabled

Enabled features

/QOpenSys/pkgs/bin /usr/bin /QSYS.lib/ILEDITOR.lib /QSYS.LIB /QIBM/ProdData/IBMiDebugService/bin
bash attr GENCMDXML.PGM QZDFMDB2.PGM startDebugService.sh
git iconv GETNEWLIBL.PGM
grep setccsid
ls
md5sum
sort
stat
tar
tn5250
Shell env
BUILDLIB=PGxx
CURLIB=PGxx
HOME=/home/PGxx
LIBLS=QTEMP QGPL HAWKEYE WFISRC WAEOBJ WAEDTA ACMSLIB AFPTOOL SPLTOOL TAATOOL WFIOBJ WFIHST WFINEP WFIDTA WFIQUAL WFIINTG DTSDCDTA DTSCNTRL DTSUSER DTSQUAL DTSQUAL92 DTSINTG DTSINTG92 DEVOBJ DEVDTA DEVSRC DEVQUAL WSBSRC WSBOBJ WSBDTA WSBQUAL WSBINTG WSBUSR WIASPUSR PGxx
LMI_REL_IDLIB=WFIOBJ
LMI_REL_IDLIBS=WFIOBJ,WFICVT
LOGIN=PGxx
LOGNAME=PGxx
MAIL=/var/spool/mail/PGxx
OLDPWD=/home/PGxx
PATH=/QOpenSys/usr/bin:/usr/ccs/bin:/QOpenSys/usr/bin/X11:/usr/sbin:.:/usr/bin
PCR=PCR0000000
PROFILENAME=BASE: PGxx
PWD=/home/PGxx
REL=BASE
SHELL=/QOpenSys/pkgs/bin/bash
SHLVL=1
SSH_CLIENT=10.10.0.118 62317 22
SSH_CONNECTION=10.10.0.118 62317 10.0.4.31 22
TZ=<MST>7<MDT>,M3.2.0,M11.1.0
USER=PGxx
USERNAME=PGxx
_=/QOpenSys/usr/bin/env
Variants
{
  "american": "#@$",
  "local": "#@$"
}
Errors
[
  {
    "command": "system \"CRTLIB LIB(ILEDITOR) TEXT('Code for i temporary objects. May be cleared.')\"",
    "code": 255,
    "stderr": "CPF2111: Library ILEDITOR already exists.",
    "cwd": "/home/PGxx/builds/MySource/"
  },
  {
    "command": "system \"DLTOBJ OBJ(ILEDITOR/O_*) OBJTYPE(*FILE)\"",
    "code": 255,
    "stderr": "CPF2125: No objects deleted.",
    "cwd": "/home/PGxx/builds/MySource/"
  }
]

Image of test member for colors.
image
How it looks through SEU
image

HILITE.IMG.txt

@worksofliam worksofliam linked a pull request Feb 28, 2024 that will close this issue
5 tasks
@worksofliam worksofliam linked a pull request Sep 3, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant