Merge pull request #114 from codecademy-engineering/lindsay-cron-volumes

add volumes to cron jobs

.github/workflows/lint-test.yaml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
@@ -31,7 +31,7 @@ jobs:
         run: |
           changed=$(ct list-changed --config ct.yaml)
           if [[ -n "$changed" ]]; then
-            echo "::set-output name=changed::true"
+            echo "changed=true" >> $GITHUB_OUTPUT
           fi
 
       - name: Run chart-testing (lint)

.gitignore

@@ -1,3 +1,6 @@
 # Helm chart automated files
 /*/charts
 /*/requirements.lock
+
+# VIM
+*.swp

charts/service/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: service
 description: A generic k8s service chart
 type: application
-version: 1.8.10
+version: 1.8.11
 maintainers:
   - email: [email protected]
     name: devops

charts/service/ci/custom-values.yaml

@@ -87,11 +87,11 @@ cronJobs:
       limits:
         cpu: 10m
         memory: 50Mi
-    schedule: "* * * * *"
+    schedule: '* * * * *'
   - name: bar
     image: alpine
-    tag: "3.16"
-    command: ["echo", "FOOBAR"]
+    tag: '3.16'
+    command: ['echo', 'FOOBAR']
     useParentEnv: false
     resources:
       requests:
@@ -100,7 +100,31 @@ cronJobs:
       limits:
         cpu: 10m
         memory: 50Mi
-    schedule: "* * * * *"
+    schedule: '* * * * *'
+    volumeMounts:
+      - name: test-cron
+        mountPath: /tmp/
+    volumes:
+      - name: test-cron
+        emptyDir: {}
+
+jobs:
+  - name: 'predeploy-job'
+    command: ['nginx', '-v']
+    resources:
+      requests:
+        cpu: 10m
+        memory: 50Mi
+      limits:
+        cpu: 10m
+        memory: 50Mi
+    volumeMounts:
+      - name: test-job
+        mountPath: /tmp/
+    volumes:
+      - name: test-job
+        emptyDir: {}
+    ttlSecondsAfterFinished: 30
 
 hostAliases:
   - ip: 0.0.0.0

charts/service/templates/cronjob.yaml

@@ -80,6 +80,14 @@ spec:
             {{- end }}
             resources:
               {{- toYaml .resources | nindent 14 }} 
+            {{- with .volumeMounts }}
+            volumeMounts:
+              {{- toYaml . | nindent 14 }}
+            {{- end }}
           restartPolicy: {{ .restartPolicy | default "OnFailure" }}
+          {{- with .volumes }}
+          volumes:
+            {{- toYaml . | nindent 12 }}
+          {{- end }}
   schedule: {{ .schedule | quote }}
 {{- end }}