Merge pull request #113 from codecademy-engineering/lindsay-cron-images

add ability to set custom image/tag for crons
codecademy-engineering · Jan 31, 2024 · e08c36a · e08c36a
2 parents b0df85d + 6d4acf5
commit e08c36a
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/charts/service/Chart.yaml b/charts/service/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: service
 description: A generic k8s service chart
 type: application
-version: 1.8.9
+version: 1.8.10
 maintainers:
   - email: [email protected]
     name: devops
diff --git a/charts/service/ci/custom-values.yaml b/charts/service/ci/custom-values.yaml
@@ -88,6 +88,19 @@ cronJobs:
         cpu: 10m
         memory: 50Mi
     schedule: "* * * * *"
+  - name: bar
+    image: alpine
+    tag: "3.16"
+    command: ["echo", "FOOBAR"]
+    useParentEnv: false
+    resources:
+      requests:
+        cpu: 10m
+        memory: 50Mi
+      limits:
+        cpu: 10m
+        memory: 50Mi
+    schedule: "* * * * *"
 
 hostAliases:
   - ip: 0.0.0.0

diff --git a/charts/service/templates/cronjob.yaml b/charts/service/templates/cronjob.yaml
@@ -29,7 +29,7 @@ spec:
         spec:
           serviceAccountName: {{ $serviceAccountName }}
           containers:
-          - image: "{{ $image }}:{{ $tag }}"
+          - image: "{{ .image | default $image }}:{{ .tag | default $tag }}"
             imagePullPolicy: {{ $imagePullPolicy }}
             name: {{ .name }}
             env: