roachtest/mixedversion: TestTestPlanner should restore default version #140753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We saw that `Test_maxNumPlanSteps` suddenly failed in an otherwise unrelated backport [1]. The reason turned out to be non-determinisim. That is, a different unit test, namely `TestTestPlanner` did not restore the default version (`clusterupgrade.TestBuildVersion`). This change forwardports the missing restore to ensure future test executions follow the same PRNG sequence. [1] cockroachdb#140674 Epic: none Release note: None
srosenberg
requested review from
herkolategan and
DarrylWong
and removed request for
a team
|
This change is |
herkolategan
approved these changes
Feb 10, 2025
DarrylWong
approved these changes
Feb 10, 2025
|
TFTR! bors r=herkolategan,darrylwon |
craig bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
140753: roachtest/mixedversion: TestTestPlanner should restore default version r=herkolategan,darrylwon a=srosenberg We saw that `Test_maxNumPlanSteps` suddenly failed in an otherwise unrelated backport [1]. The reason turned out to be non-determinisim. That is, a different unit test, namely `TestTestPlanner` did not restore the default version (`clusterupgrade.TestBuildVersion`). This change forwardports the missing restore to ensure future test executions follow the same PRNG sequence. [1] #140674 Epic: none Release note: None Co-authored-by: Stan Rosenberg <[email protected]>
|
Build failed: |
|
bors retry |
craig bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
140753: roachtest/mixedversion: TestTestPlanner should restore default version r=herkolategan,darrylwon a=srosenberg We saw that `Test_maxNumPlanSteps` suddenly failed in an otherwise unrelated backport [1]. The reason turned out to be non-determinisim. That is, a different unit test, namely `TestTestPlanner` did not restore the default version (`clusterupgrade.TestBuildVersion`). This change forwardports the missing restore to ensure future test executions follow the same PRNG sequence. [1] #140674 Epic: none Release note: None 140785: rac2,kvserver: start the StreamCloseScheduler r=sumeerbhola a=pav-kv This commit enables the `StreamCloseScheduler`, which is responsible for closing RACv2 streams some time (400ms) after they enter `StateProbe`. The initialization had to move from `NewStore` to `Store.Start()` because it needs the `stopper` to start the job. Epic: none Release note: none 140791: sem/tree: avoid assertion error on unimplemented builtins in views r=yuzefovich a=yuzefovich Previously, we would hit an assertion error when trying to use an unimplemented builtin in the CREATE VIEW statement and this is now fixed. The issue is that we resolve unimplemented builtins as a definition with zero overloads, and all places that previously assumed at least one existing overload have been audited. The resolved function definition has been updated to have "unsupported with issue" integer indicating why there are no overloads. Additionally, `UnsupportedWithIssue` property is now changed to be `uint` since we didn't use "negative value as having no corresponding issue" ability. I decided to not include a release note since this seems like an edge case and we've only seen this a handful of times in sentry. Fixes: #128535. Release note: None 141009: sqlstats: use `BatchProcessLatencyBuckets` for flush latency r=xinhaoz a=dhartunian The max of 10s on the IO latency buckets is too short to measure flush latency effectively. Previously, this metric was measuring per-statement flush latency, but this was altered in #122919. Release note: None Co-authored-by: Stan Rosenberg <[email protected]> Co-authored-by: Pavel Kalinnikov <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: David Hartunian <[email protected]>
|
Build failed (retrying...): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw that
Test_maxNumPlanStepssuddenly failed in an otherwise unrelated backport [1]. The reason turned out to be non-determinisim. That is, a differentunit test, namely
TestTestPlannerdid notrestore the default version (
clusterupgrade.TestBuildVersion).This change forwardports the missing restore to
ensure future test executions follow the same
PRNG sequence.
[1] #140674
Epic: none
Release note: None