release-25.1: roachtest/mixedversion: TestTestPlanner should restore default version #141025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #140753 on behalf of @srosenberg.
/cc @cockroachdb/release
We saw that
Test_maxNumPlanSteps
suddenly failed in an otherwise unrelated backport [1]. The reason turned out to be non-determinisim. That is, a differentunit test, namely
TestTestPlanner
did notrestore the default version (
clusterupgrade.TestBuildVersion
).This change forwardports the missing restore to
ensure future test executions follow the same
PRNG sequence.
[1] #140674
Epic: none
Release note: None
Release justification: test-only change