Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-25.1: roachtest/mixedversion: TestTestPlanner should restore default version #141025

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Feb 10, 2025

Backport 1/1 commits from #140753 on behalf of @srosenberg.

/cc @cockroachdb/release


We saw that Test_maxNumPlanSteps suddenly failed in an otherwise unrelated backport [1]. The reason turned out to be non-determinisim. That is, a different
unit test, namely TestTestPlanner did not
restore the default version (clusterupgrade.TestBuildVersion).

This change forwardports the missing restore to
ensure future test executions follow the same
PRNG sequence.

[1] #140674

Epic: none
Release note: None


Release justification: test-only change

We saw that `Test_maxNumPlanSteps` suddenly failed in an
otherwise unrelated backport [1]. The reason turned
out to be non-determinisim. That is, a different
unit test, namely `TestTestPlanner` did not
restore the default version (`clusterupgrade.TestBuildVersion`).

This change forwardports the missing restore to
ensure future test executions follow the same
PRNG sequence.

[1] #140674

Epic: none

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner February 10, 2025 20:44
@blathers-crl blathers-crl bot removed the request for review from a team February 10, 2025 20:44
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-25.1-140753 branch from a7be1b7 to 0715fe5 Compare February 10, 2025 20:44
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Feb 10, 2025
@blathers-crl blathers-crl bot requested a review from DarrylWong February 10, 2025 20:44
Copy link
Author

blathers-crl bot commented Feb 10, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Feb 10, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@srosenberg
Copy link
Member

TFTR!

@srosenberg srosenberg merged commit 60ead0e into release-25.1 Feb 13, 2025
15 of 16 checks passed
@srosenberg srosenberg deleted the blathers/backport-release-25.1-140753 branch February 13, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants