tasks: Install ruff #551
Merged
tasks: Install ruff #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We haven't used the Fedora package after all, this does not work at all due to overly strict version checks. This reverts commit 0c6bdf9.
In our projects we have used ruff long enough to commit to it. Let's have it in our development toolboxes by default then, so that we don't keep sending PRs which break ruff rules. This also enables our other projects to start using ruff in CI (which runs in tasks, instead of a dedicated unit-tests container).
This was referenced Jun 22, 2023
|
@jelly , @allisonkarlitskaya : Gentle review ping? |
jelly
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our projects we have used ruff long enough to commit to it. Let's
have it in our development toolboxes by default then, so that we don't
keep sending PRs which break ruff rules.
This also enables our other projects to start using ruff in CI (which
runs in tasks, instead of a dedicated unit-tests container).