Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix spelling of --enable-pybridge option #18990

Merged

Conversation

mvollmer
Copy link
Member

Giving --enable-pybridge to configure works as intended, but there will be a warning as well because it is mispelled in one place:

configure: WARNING: unrecognized options: --enable-pybridge

@mvollmer mvollmer requested a review from martinpitt June 22, 2023 06:44
martinpitt
martinpitt previously approved these changes Jun 22, 2023
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, thanks!

@martinpitt martinpitt force-pushed the build-fix-enable-pybridge-spelling branch from a922cd2 to 613fc80 Compare June 22, 2023 07:30
@martinpitt
Copy link
Member

Rebased to current main, needed a restart due to rolling out new tasks containers.

@martinpitt
Copy link
Member

pixels need updating because we just got a new browser, see cockpit-project/cockpituous#551

Giving --enable-pybridge to configure works as intended, but there
will be a warning as well because it is mispelled in one place:

    configure: WARNING: unrecognized options: --enable-pybridge
Copy link
Member

@allisonkarlitskaya allisonkarlitskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 thanks

@martinpitt martinpitt added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Jun 22, 2023
@martinpitt martinpitt force-pushed the build-fix-enable-pybridge-spelling branch from acbf7f1 to dc8e4a4 Compare June 22, 2023 08:51
@martinpitt
Copy link
Member

Ah, forgot the other batch

The recent cockpit/tasks refresh got a new Chromium version, which
causes subtle pixel changes.
@martinpitt martinpitt force-pushed the build-fix-enable-pybridge-spelling branch from dc8e4a4 to 91102fd Compare June 22, 2023 09:31
@martinpitt martinpitt merged commit a37625a into cockpit-project:main Jun 22, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants