containers/ws: Enable beibooting and install standard cockpit pages #21042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
added
blocked
cockpituous
reviewed
Sep 26, 2024
pkg/static/login.js
Outdated
Comment on lines
863
to
864
| console.error("login: got unexpected host key prompt, expecting login-data placeholder:", key); | ||
| fatal(_("Internal protocol error")); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
martinpitt
force-pushed
the
ws-beiboot
branch
from
5a0c357
to
b448046
Compare
11 tasks
martinpitt
removed
the
blocked
martinpitt
force-pushed
the
ws-beiboot
branch
from
b448046
to
2c8f283
Compare
This provides similar functionality as the Client, so that the ws bastion container can connect to machines which don't have any Cockpit packages installed. Install cockpit-system and cockpit-networkmanager into the container (we'll likely expand this in the future, but let's start small). Take care to only unpack the RPMs, to avoid installing e.g. NetworkManager and other big dependencies into the container -- they are useless there. Update the documentation accordingly. While at it, add an introduction paragraph what Cockpit is. https://issues.redhat.com/browse/COCKPIT-954
martinpitt
force-pushed
the
ws-beiboot
branch
from
2c8f283
to
819293d
Compare
mvollmer
reviewed
Oct 1, 2024
|
|
||
| If you want to also run a web server to log in directly on the CoreOS host, you | ||
| can use this container in two modes. | ||
| This web server can be deployed as container. It has two modes, which are described below. |
mvollmer
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides similar functionality as the Client, so that the ws
bastion container can connect to machines which don't have any Cockpit
packages installed.
Install cockpit-system and cockpit-networkmanager into the container for
now. We'll likely expand this in the future, but let's start small.
https://issues.redhat.com/browse/COCKPIT-954
cockpit/ws container: Connect to servers without installed Cockpit
The quay.io/cockpit/ws container provides Cockpit's web server in environments such as Kubernetes or Fedora CoreOS. It connects to a destination machine via
ssh.Similarly to what the Cockpit Client flatpak supports since release 295, that container can now connect to hosts which don't have any Cockpit packages installed. This version starts a basic set of pages (Overview, Metrics, Terminal, Accounts, and Networking). We will add further pages soon, after vetting them for this use case.