Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: Replace cockpit-ssh with cockpit.beiboot #19441

Merged
merged 14 commits into from
Sep 30, 2024
Merged

ssh: Replace cockpit-ssh with cockpit.beiboot #19441

merged 14 commits into from
Sep 30, 2024

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Oct 5, 2023 •
edited
Loading

https://issues.redhat.com/browse/COCKPIT-1029

TODO:

@martinpitt martinpitt added blocked Don't land until something else happens first (see task list) no-test For doc/workflow changes, or experiments which don't need a full CI run, labels Oct 5, 2023
@martinpitt martinpitt mentioned this pull request Oct 6, 2023
Merged
4 tasks
@martinpitt martinpitt force-pushed the beiboot-default branch 2 times, most recently from 88c969d to 3b3581c Compare October 6, 2023 06:06
@martinpitt martinpitt changed the title ssh: Replace cockpit-ssh with cockpit.beiboot with the pybridge ssh: Replace cockpit-ssh with cockpit.beiboot Mar 22, 2024
@martinpitt martinpitt mentioned this pull request Mar 22, 2024
Merged
@martinpitt martinpitt force-pushed the beiboot-default branch 3 times, most recently from c34aa52 to ab45c5a Compare September 3, 2024 12:53
@martinpitt martinpitt force-pushed the beiboot-default branch 3 times, most recently from a5197b7 to 43ee8f1 Compare September 20, 2024 13:11
@martinpitt martinpitt removed blocked Don't land until something else happens first (see task list) no-test For doc/workflow changes, or experiments which don't need a full CI run, labels Sep 23, 2024
@martinpitt martinpitt force-pushed the beiboot-default branch 4 times, most recently from 3347541 to 52642f4 Compare September 24, 2024 09:56
@martinpitt martinpitt mentioned this pull request Sep 24, 2024
Open
@martinpitt martinpitt force-pushed the beiboot-default branch 5 times, most recently from 88a2c92 to c23b02a Compare September 25, 2024 08:53
@martinpitt
Copy link
Member Author

martinpitt commented Sep 25, 2024 •
edited
Loading

🥳 Green! I may do some more cleanup now, but just in case I break things again 😓 Green was on commit c23b02a.

@martinpitt martinpitt marked this pull request as ready for review September 25, 2024 10:16
@martinpitt
Copy link
Member Author

@mvollmer Thanks for your careful review! The interdiff has a rebase and fixes for the two remaining outstanding threads.

cockpituous
cockpituous reviewed Sep 27, 2024
View reviewed changes
pkg/static/login.js
Comment on lines +863 to +864
console.error("login: got unexpected host key prompt, expecting login-data placeholder:", key);
fatal(_("Internal protocol error"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 added lines are not executed by any test.

mvollmer
mvollmer approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's christen this new dinghy!

@martinpitt
Copy link
Member Author

🍾 ⛵

There once was a ship that put to sea
The name of the ship was cockpit beiboot

@martinpitt martinpitt merged commit 6dd41b5 into cockpit-project:main Sep 30, 2024
88 checks passed
@martinpitt martinpitt deleted the beiboot-default branch September 30, 2024 07:36
This was referenced Sep 30, 2024
Merged
Merged
martinpitt added a commit to martinpitt/bots that referenced this pull request Oct 1, 2024
@martinpitt
images: Drop libssh from Arch image
cff7e34 
Build and runtime dependency was dropped in
cockpit-project/cockpit#19441
martinpitt added a commit to martinpitt/bots that referenced this pull request Oct 1, 2024
@martinpitt
images: Drop explicit libssh
72a4afc 
This has been unnecessary since commit b06bd37, as installing
cockpit-bridge brings this in as a dependency. It will actually drop
from the image after the next Cockpit release, as it was dropped in
cockpit-project/cockpit#19441
@martinpitt martinpitt mentioned this pull request Oct 1, 2024
Merged
1 task
martinpitt added a commit to martinpitt/bots that referenced this pull request Oct 1, 2024
@martinpitt
images: Drop explicit libssh from Debian
8707e1f 
This has been unnecessary since commit b06bd37, as installing
cockpit-bridge brings this in as a dependency. It will actually drop
from the image after the next Cockpit release, as it was dropped in
cockpit-project/cockpit#19441
martinpitt added a commit to martinpitt/bots that referenced this pull request Oct 1, 2024
@martinpitt
images: Drop explicit libssh from Fedora
aea88ad 
The explicit runtime dependency has been unnecessary since commit
9a6962d, as installing cockpit-bridge brings this in as a dependency.
It will actually drop from the image after the next Cockpit release, as
it was dropped in cockpit-project/cockpit#19441

Also drop it from the base container.
martinpitt added a commit to martinpitt/bots that referenced this pull request Oct 1, 2024
@martinpitt
images: Drop explicit libssh from RHEL
3b9081b 
This has been unnecessary for many years, as installing cockpit-bridge
brings this in as a dependency. It will actually drop from most images
(except for RHEL 8) after the next Cockpit release, as it was dropped in
cockpit-project/cockpit#19441
@martinpitt martinpitt mentioned this pull request Oct 1, 2024
Merged
1 task
martinpitt added a commit to martinpitt/cockpit that referenced this pull request Oct 1, 2024
@martinpitt
Drop remaining libssh references
9b8aafc 
Cleanup after cockpit-project#19441. In particular, drop the dependency in the Arch
packaging.
@martinpitt martinpitt mentioned this pull request Oct 1, 2024
Merged
mvollmer pushed a commit to cockpit-project/bots that referenced this pull request Oct 1, 2024
@martinpitt @mvollmer
images: Drop explicit libssh from RHEL
d545aa6 
This has been unnecessary for many years, as installing cockpit-bridge
brings this in as a dependency. It will actually drop from most images
(except for RHEL 8) after the next Cockpit release, as it was dropped in
cockpit-project/cockpit#19441
jelly pushed a commit to cockpit-project/bots that referenced this pull request Oct 1, 2024
@martinpitt @jelly
images: Drop explicit libssh from Fedora
01f61d0 
The explicit runtime dependency has been unnecessary since commit
9a6962d, as installing cockpit-bridge brings this in as a dependency.
It will actually drop from the image after the next Cockpit release, as
it was dropped in cockpit-project/cockpit#19441

Also drop it from the base container.
jelly pushed a commit to cockpit-project/bots that referenced this pull request Oct 1, 2024
@martinpitt @jelly
images: Drop explicit libssh from Debian
474a7d2 
This has been unnecessary since commit b06bd37, as installing
cockpit-bridge brings this in as a dependency. It will actually drop
from the image after the next Cockpit release, as it was dropped in
cockpit-project/cockpit#19441
jelly pushed a commit to cockpit-project/bots that referenced this pull request Oct 1, 2024
@martinpitt @jelly
images: Drop libssh from Arch image
2a69768 
Build and runtime dependency was dropped in
cockpit-project/cockpit#19441
martinpitt added a commit that referenced this pull request Oct 1, 2024
@martinpitt
Drop remaining libssh references
dc2085e 
Cleanup after #19441. In particular, drop the dependency in the Arch
packaging.
@martinpitt martinpitt mentioned this pull request Oct 2, 2024
Merged
1 task
martinpitt added a commit to martinpitt/bots that referenced this pull request Oct 2, 2024
@martinpitt
images: Drop explicit libssh2 dependency on opensuse-tumbleweed
5fb0039 
This has never been necessary, as the image pre-installs the whole
`cockpit` package, which pulls it in as a dependency. This
build/runtime dependency was dropped in
cockpit-project/cockpit#19441
jelly pushed a commit to cockpit-project/bots that referenced this pull request Oct 2, 2024
@martinpitt @jelly
images: Drop explicit libssh2 dependency on opensuse-tumbleweed
b236d36 
This has never been necessary, as the image pre-installs the whole
`cockpit` package, which pulls it in as a dependency. This
build/runtime dependency was dropped in
cockpit-project/cockpit#19441
garrett pushed a commit to martinpitt/cockpit that referenced this pull request Oct 8, 2024
@martinpitt @garrett
Drop remaining libssh references
38466eb 
Cleanup after cockpit-project#19441. In particular, drop the dependency in the Arch
packaging.
mvollmer pushed a commit to mvollmer/cockpit that referenced this pull request Oct 9, 2024
@martinpitt @mvollmer
Drop remaining libssh references
69812d7 
Cleanup after cockpit-project#19441. In particular, drop the dependency in the Arch
packaging.
SludgeGirl pushed a commit to Nykseli/cockpit that referenced this pull request Nov 12, 2024
@martinpitt @SludgeGirl
Drop remaining libssh references
e1c8888 
Cleanup after cockpit-project#19441. In particular, drop the dependency in the Arch
packaging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cockpituous cockpituous cockpituous left review comments

@mvollmer mvollmer mvollmer approved these changes

@jelly jelly Awaiting requested review from jelly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinpitt @mvollmer @cockpituous