test: wait on new image tag #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ding ding ding, fails in some cases still so this needs to be conditional |
martinpitt
requested changes
Nov 8, 2024
The image has two tags, but which one is shown is not predictable which is the issue shown in the failing tests. Either the UI does not update or it is unpredicable. |
|
Cool this works now |
testDownloadImage flaked a very often as the test succeeds when runs fast enough. Tagging an image to a new name in this case sometimes changes the image list name to `copybox` instead of `my-busybox which causes the test to flake.
jelly
force-pushed
the
test-downloadimage-flake
branch
from
2348edb
to
ee68115
Compare
|
this looks like flake, /me leans on retry button |
martinpitt
approved these changes
Nov 11, 2024
Yup, apparently that is not deterministic :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testDownloadImage flaked a very often as the test succeeds when runs fast enough. Tagging an image to a new name in this case changes the image list name to
copyboxpossibly because it is sorted beforemy-busybox.Alternatively we can wait on either?