Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Update Cockpit lib to c295842a0336c9e967a0c5adc28ddf52 #1906

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 7, 2024

Jelle van der Waa (2):
test: restore fstab/crypttab for RHEL 8 storage tests
lib: restrict SASS plugin to scss files

Marius Vollmer (10):
lib: Copy TypeaheadSelect into our code
lib: Fix TypeScript error in TypeaheadSelect
lib: Optionally trust selected property in TypeaheadSelect
lib: Support dividers with TypeaheadSelect
lib: Hide clear button in TypeaheadSelect when it would do nothing
lib: Simplify and translate UI texts in TypeaheadSelect
storage: Use TypeaheadSelect instead of deprecated Select
lib: Use TypeaheadSelect instead of deprecated Select for timezones
lib: Use TypeaheadSelect instead of deprecated Select for FileAutoComplete
lib: Fix TypeScript error in TypeaheadSelect correctly

Martin Pitt (4):
lib: Properly type getLastlog2
lib: Add typing for cockpit.jump() and cockpit.dbus().call()
lib: Initial typing of python.js
base1: Make TransportGlobals actually global

@github-actions github-actions bot added the bot label Nov 7, 2024
@github-actions github-actions bot changed the title [no-test] Makefile: Update Cockpit lib to c295842a0336c9e967a0c5adc28ddf52 Makefile: Update Cockpit lib to c295842a0336c9e967a0c5adc28ddf52 Nov 7, 2024
@allisonkarlitskaya allisonkarlitskaya force-pushed the cockpit-lib-update-cockpit-lib-20241107-024339 branch from cdc42eb to 08364d5 Compare November 7, 2024 02:43
@martinpitt
Copy link
Member

Related to the TypeaheadSelect changes, @jelly was looking into these for c-machines. Otherwise this can wait for next week when @mvollmer comes back.

@jelly jelly force-pushed the cockpit-lib-update-cockpit-lib-20241107-024339 branch from d791e47 to 2b78c0f Compare November 7, 2024 15:51
The component now uses a non-deprecated select component which has a
different css selector.
@jelly jelly force-pushed the cockpit-lib-update-cockpit-lib-20241107-024339 branch from 2b78c0f to 715e37f Compare November 7, 2024 16:20
@jelly
Copy link
Member

jelly commented Nov 7, 2024

So testDownloadImage just flakes very badly, but mostly on F41:

        second_tag = "localhost/copybox:latest"
        self.execute(False, f"podman tag localhost:5000/my-busybox {second_tag}")
        # expand details
        b.click("#containers-images tr:contains('my-busybox') td.pf-v5-c-table__toggle button")
        b.wait_in_text("#containers-images tbody.pf-m-expanded tr .image-details", second_tag)

Can reproduce the test failure here, the copyobx tag takes precedence over the old tag:

image

Did the test always succeed as the UI didn't update fast enough?

Flake curing attempt here #1907

@jelly
Copy link
Member

jelly commented Nov 11, 2024

Bunch of retries due to flake ^, will fix that separately

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dankjewel!

@martinpitt martinpitt merged commit 8722224 into main Nov 11, 2024
34 checks passed
@martinpitt martinpitt deleted the cockpit-lib-update-cockpit-lib-20241107-024339 branch November 11, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants