Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix magic env var value auto-splitting #1833

Merged
merged 1 commit into from
Aug 22, 2024

Commits on Aug 22, 2024

  1. Fix magic env var value auto-splitting

    The `companionField` in handleEnvValue() is meant to be the *other*
    (key/value) field. It doesn't make sense to specify its own value, that
    just looked like a copy&paste error from the *-key input handler.
    
    With that you can type "FOO=bar" and get the automatic split. The test
    "cheated" with `set_val()` which sets all letters atomically. Test
    "RHUBARB=STRAWBERRY" separately with proper keyboard input.
    
    Splitting muliple variables can only work with an atomic value setting,
    i.e. the user doing copy&paste. Keep the `set_val()` bit and explain it,
    and also validate that the fields get created and split as expected.
    martinpitt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    20c3a4b View commit details
    Browse the repository at this point in the history