Fix magic env var value auto-splitting #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
martinpitt
commented
Aug 21, 2024
martinpitt
force-pushed
the
fix-env-split
branch
from
df5b0ce
to
e275ed7
Compare
The `companionField` in handleEnvValue() is meant to be the *other* (key/value) field. It doesn't make sense to specify its own value, that just looked like a copy&paste error from the *-key input handler. With that you can type "FOO=bar" and get the automatic split. The test "cheated" with `set_val()` which sets all letters atomically. Test "RHUBARB=STRAWBERRY" separately with proper keyboard input. Splitting muliple variables can only work with an atomic value setting, i.e. the user doing copy&paste. Keep the `set_val()` bit and explain it, and also validate that the fields get created and split as expected.
martinpitt
force-pushed
the
fix-env-split
branch
from
e275ed7
to
20c3a4b
Compare
martinpitt
changed the title
jelly
approved these changes
Aug 22, 2024
|
Re-triggered ubuntu-2204 |
|
That healthcheck failure is the number #1 failure on the weather report and keeps getting caught in the 3x affected retries. Unrelated to this PR. I already retried it here, but I'll wait for your current retry run. |
And it went green 🍀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
companionFieldin handleEnvValue() is meant to be the other (key/value) field. It doesn't make sense to specify its own value, that just looked like a copy&paste error from the *-key input handler.With that you can type "FOO=bar" and get the automatic split. The test "cheated" with
set_val()which sets all letters atomically. Test "RHUBARB=STRAWBERRY" separately with proper keyboard input.Splitting muliple variables can only work with an atomic value setting, i.e. the user doing copy&paste. Keep the
set_val()bit and explain it, and also validate that the fields get created and split as expected.Spotted as part of #1832. It may help with the testRunImageUser failure, but it's confusing/obvious enough to be a good bug fix even if it doesn't fix that particular race.
I triggered an extra /firefox run.