Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Update Cockpit lib to 140b7e62f5cfcad5ad9105867474526ef68351db #1312

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Makefile: Update Cockpit lib to 140b7e62f5cfcad5ad9105867474526ef68351db #1312

merged 2 commits into from
Nov 16, 2023

Commits on Nov 16, 2023

  1. test: Fix dialog handling 

    Close the dialog in the "does not oops" and "add disk xfail" checks,
otherwise the test continues fumbling the main page and opening new
dialogs underneath the existing open one. That's cheating and a source
for race conditions.

Fix other places which close dialogs but don't wait for it to go away.

This uncovered a place which wants to open a new "add disk" dialog, and
forgot to switch to "Custom path" mode. This worked before as the
previous dialog was still open and happened to be in that mode.
    @martinpitt
    martinpitt committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    dd9fb75 View commit details
    Browse the repository at this point in the history

  2. Makefile: Update Cockpit lib to 140b7e62f5cfcad5ad9105867474526ef68351db 

    Closes #1312
    @cockpituous @martinpitt
    cockpituous authored and martinpitt committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    1e0943b View commit details
    Browse the repository at this point in the history