Makefile: Update Cockpit lib to 140b7e62f5cfcad5ad9105867474526ef68351db #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
changed the title
github-actions
bot
force-pushed
the
cockpit-lib-update-cockpit-lib-20231116-022114
branch
from
843a423
to
84c4abd
Compare
|
A-ha! Dialogs on top of each other! That's actually what I wanted to check for last week already after cockpit-project/cockpit#19595 , but didn't get around to it. Looking.. |
martinpitt
pushed a commit
that referenced
this pull request
Nov 16, 2023
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20231116-022114
branch
from
84c4abd
to
13c0859
Compare
martinpitt
changed the title
martinpitt
pushed a commit
that referenced
this pull request
Nov 16, 2023
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20231116-022114
branch
from
13c0859
to
2c6f469
Compare
Close the dialog in the "does not oops" and "add disk xfail" checks, otherwise the test continues fumbling the main page and opening new dialogs underneath the existing open one. That's cheating and a source for race conditions. Fix other places which close dialogs but don't wait for it to go away. This uncovered a place which wants to open a new "add disk" dialog, and forgot to switch to "Custom path" mode. This worked before as the previous dialog was still open and happened to be in that mode.
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20231116-022114
branch
from
2c6f469
to
1e0943b
Compare
jelly
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.