Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle 7.6 #1466

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Checkstyle 7.6 #1466

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f21869
CheckstyleBear: Upgrade checkstyle 6.15 to 7.6
jayvdb Feb 27, 2017
a204ccd
manual check
jayvdb Apr 25, 2017
834f839
Run checkstyle on command line
jayvdb Apr 26, 2017
9b7d2f5
Use Java 1.8
jayvdb Apr 26, 2017
8d6affe
remove quotes
jayvdb Apr 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .ci/appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ test_script:
# Force DOS format, as Checkstyle configs enable NewlineAtEndOfFile,
# which defaults to CRLF on Windows, and Appveyor CI ignores .gitattributes
# http://help.appveyor.com/discussions/problems/5687-gitattributes-changes-dont-have-any-effect
- unix2dos tests/java/test_files/CheckstyleBad.java
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section ci.

The issue can be fixed by applying the following patch:

--- a/.ci/appveyor.yml
+++ b/.ci/appveyor.yml
@@ -55,7 +55,7 @@
   # http://help.appveyor.com/discussions/problems/5687-gitattributes-changes-dont-have-any-effect
   - unix2dos tests/java/test_files/CheckstyleBad.java
   - unix2dos tests/java/test_files/CheckstyleGood.java
-  - appveyor DownloadFile https://github.com/coala/bear-runtime-deps/raw/master/CheckstyleBear/checkstyle-7.6-all.jar checkstyle-7.6-all.jar 
+  - appveyor DownloadFile https://github.com/coala/bear-runtime-deps/raw/master/CheckstyleBear/checkstyle-7.6-all.jar checkstyle-7.6-all.jar
   - java -jar checkstyle-7.6-all.jar -c '/google_checks.xml' tests/java/test_files/CheckstyleBad.java
   # Clang DLLs x64 were nowadays installed, but the x64 version hangs, so we
   # exclude according tests. See https://github.com/appveyor/ci/issues/495 and

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section ci.

The issue can be fixed by applying the following patch:

--- a/.ci/appveyor.yml
+++ b/.ci/appveyor.yml
@@ -55,7 +55,7 @@
   # http://help.appveyor.com/discussions/problems/5687-gitattributes-changes-dont-have-any-effect
   - unix2dos tests/java/test_files/CheckstyleBad.java
   - unix2dos tests/java/test_files/CheckstyleGood.java
-  - appveyor DownloadFile https://github.com/coala/bear-runtime-deps/raw/master/CheckstyleBear/checkstyle-7.6-all.jar checkstyle-7.6-all.jar 
+  - appveyor DownloadFile https://github.com/coala/bear-runtime-deps/raw/master/CheckstyleBear/checkstyle-7.6-all.jar checkstyle-7.6-all.jar
   - java -jar checkstyle-7.6-all.jar -c '/google_checks.xml' tests/java/test_files/CheckstyleBad.java
   # Clang DLLs x64 were nowadays installed, but the x64 version hangs, so we
   # exclude according tests. See https://github.com/appveyor/ci/issues/495 and

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section ci.

The issue can be fixed by applying the following patch:

--- a/.ci/appveyor.yml
+++ b/.ci/appveyor.yml
@@ -55,7 +55,7 @@
   # http://help.appveyor.com/discussions/problems/5687-gitattributes-changes-dont-have-any-effect
   - unix2dos tests/java/test_files/CheckstyleBad.java
   - unix2dos tests/java/test_files/CheckstyleGood.java
-  - appveyor DownloadFile https://github.com/coala/bear-runtime-deps/raw/master/CheckstyleBear/checkstyle-7.6-all.jar checkstyle-7.6-all.jar 
+  - appveyor DownloadFile https://github.com/coala/bear-runtime-deps/raw/master/CheckstyleBear/checkstyle-7.6-all.jar checkstyle-7.6-all.jar
   - java -jar checkstyle-7.6-all.jar -c '/google_checks.xml' tests/java/test_files/CheckstyleBad.java
   # Clang DLLs x64 were nowadays installed, but the x64 version hangs, so we
   # exclude according tests. See https://github.com/appveyor/ci/issues/495 and

- unix2dos tests/java/test_files/CheckstyleGood.java
- appveyor DownloadFile https://github.com/coala/bear-runtime-deps/raw/master/CheckstyleBear/checkstyle-7.6-all.jar checkstyle-7.6-all.jar
- java -jar checkstyle-7.6-all.jar -c '/google_checks.xml' tests/java/test_files/CheckstyleBad.java
# Clang DLLs x64 were nowadays installed, but the x64 version hangs, so we
# exclude according tests. See https://github.com/appveyor/ci/issues/495 and
# https://github.com/appveyor/ci/issues/688
Expand Down
6 changes: 3 additions & 3 deletions bears/java/CheckstyleBear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ class CheckstyleBear:

def setup_dependencies(self):
type(self).checkstyle_jar_file = self.download_cached_file(
'http://sourceforge.net/projects/checkstyle/files/checkstyle/6.19'
'/checkstyle-6.19-all.jar',
'checkstyle-6.19.jar')
'https://github.com/coala/bear-runtime-deps/raw/master'
'/CheckstyleBear/checkstyle-7.6-all.jar',
'checkstyle-7.6-all.jar')

def create_arguments(
self, filename, file, config_file,
Expand Down