Checkstyle 7.6 #1466

jayvdb · 2017-02-27T16:12:13Z

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out
of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

gitmate-bot · 2017-03-10T00:39:55Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-03-17T10:27:07Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

sils · 2017-03-22T08:03:01Z

ack b1551ab 8bc4285 4a1123b

sils · 2017-03-22T08:04:31Z

The PR needs a rebase and conflict resolution though, also the review was done under the assumption that all tests pass which isn't true on AppVeyor.

jayvdb · 2017-03-22T08:50:23Z

This is blocked on #1527 , which turned out to have more significant problems on Windows hence needing to be worked on separately.

gitmate-bot · 2017-03-29T11:20:18Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-04-05T10:00:37Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-04-12T08:40:10Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-04-19T07:20:27Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Closes coala#1465

gitmate-bot · 2017-04-26T17:49:12Z

.ci/appveyor.yml

@@ -53,7 +53,10 @@ test_script:
  # Force DOS format, as Checkstyle configs enable NewlineAtEndOfFile,
  # which defaults to CRLF on Windows, and Appveyor CI ignores .gitattributes
  # http://help.appveyor.com/discussions/problems/5687-gitattributes-changes-dont-have-any-effect
+  - unix2dos tests/java/test_files/CheckstyleBad.java


Line contains following spacing inconsistencies:

Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section ci.

The issue can be fixed by applying the following patch:

--- a/.ci/appveyor.yml +++ b/.ci/appveyor.yml @@ -55,7 +55,7 @@ # http://help.appveyor.com/discussions/problems/5687-gitattributes-changes-dont-have-any-effect - unix2dos tests/java/test_files/CheckstyleBad.java - unix2dos tests/java/test_files/CheckstyleGood.java - - appveyor DownloadFile https://github.com/coala/bear-runtime-deps/raw/master/CheckstyleBear/checkstyle-7.6-all.jar checkstyle-7.6-all.jar + - appveyor DownloadFile https://github.com/coala/bear-runtime-deps/raw/master/CheckstyleBear/checkstyle-7.6-all.jar checkstyle-7.6-all.jar - java -jar checkstyle-7.6-all.jar -c '/google_checks.xml' tests/java/test_files/CheckstyleBad.java # Clang DLLs x64 were nowadays installed, but the x64 version hangs, so we # exclude according tests. See https://github.com/appveyor/ci/issues/495 and

gitmate-bot · 2017-04-26T18:36:27Z

.ci/appveyor.yml

@@ -53,7 +53,10 @@ test_script:
  # Force DOS format, as Checkstyle configs enable NewlineAtEndOfFile,
  # which defaults to CRLF on Windows, and Appveyor CI ignores .gitattributes
  # http://help.appveyor.com/discussions/problems/5687-gitattributes-changes-dont-have-any-effect
+  - unix2dos tests/java/test_files/CheckstyleBad.java


Line contains following spacing inconsistencies:

Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section ci.

The issue can be fixed by applying the following patch:

--- a/.ci/appveyor.yml +++ b/.ci/appveyor.yml @@ -55,7 +55,7 @@ # http://help.appveyor.com/discussions/problems/5687-gitattributes-changes-dont-have-any-effect - unix2dos tests/java/test_files/CheckstyleBad.java - unix2dos tests/java/test_files/CheckstyleGood.java - - appveyor DownloadFile https://github.com/coala/bear-runtime-deps/raw/master/CheckstyleBear/checkstyle-7.6-all.jar checkstyle-7.6-all.jar + - appveyor DownloadFile https://github.com/coala/bear-runtime-deps/raw/master/CheckstyleBear/checkstyle-7.6-all.jar checkstyle-7.6-all.jar - java -jar checkstyle-7.6-all.jar -c '/google_checks.xml' tests/java/test_files/CheckstyleBad.java # Clang DLLs x64 were nowadays installed, but the x64 version hangs, so we # exclude according tests. See https://github.com/appveyor/ci/issues/495 and

gitmate-bot · 2017-04-26T18:52:06Z

.ci/appveyor.yml

@@ -53,7 +53,10 @@ test_script:
  # Force DOS format, as Checkstyle configs enable NewlineAtEndOfFile,
  # which defaults to CRLF on Windows, and Appveyor CI ignores .gitattributes
  # http://help.appveyor.com/discussions/problems/5687-gitattributes-changes-dont-have-any-effect
+  - unix2dos tests/java/test_files/CheckstyleBad.java


Line contains following spacing inconsistencies:

Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section ci.

The issue can be fixed by applying the following patch:

--- a/.ci/appveyor.yml +++ b/.ci/appveyor.yml @@ -55,7 +55,7 @@ # http://help.appveyor.com/discussions/problems/5687-gitattributes-changes-dont-have-any-effect - unix2dos tests/java/test_files/CheckstyleBad.java - unix2dos tests/java/test_files/CheckstyleGood.java - - appveyor DownloadFile https://github.com/coala/bear-runtime-deps/raw/master/CheckstyleBear/checkstyle-7.6-all.jar checkstyle-7.6-all.jar + - appveyor DownloadFile https://github.com/coala/bear-runtime-deps/raw/master/CheckstyleBear/checkstyle-7.6-all.jar checkstyle-7.6-all.jar - java -jar checkstyle-7.6-all.jar -c '/google_checks.xml' tests/java/test_files/CheckstyleBad.java # Clang DLLs x64 were nowadays installed, but the x64 version hangs, so we # exclude according tests. See https://github.com/appveyor/ci/issues/495 and

jayvdb · 2017-04-26T19:16:47Z

The problem on Appveyor is

java -jar checkstyle-7.6-all.jar -c '/google_checks.xml' tests/java/test_files/CheckstyleBad.java
java.lang.UnsupportedClassVersionError: com/puppycrawl/tools/checkstyle/Main : Unsupported major.minor version 52.0
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:800)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:449)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:71)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
	at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:482)
Exception in thread "main" Command exited with code 1

52.0 is Java 8.

jayvdb · 2017-04-26T19:19:33Z

Created issue #1675 about this.

gitmate-bot · 2017-05-04T02:53:50Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-05-11T07:43:34Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-05-18T06:23:46Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-05-18T06:23:46Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-05-25T05:04:00Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-06-01T03:43:46Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-06-01T03:43:46Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-06-08T02:24:22Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-06-15T01:04:36Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-06-21T23:44:05Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-06-28T22:24:13Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-07-05T21:04:32Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-07-12T19:44:24Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-07-20T05:30:54Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot added process/pending review size/S labels Feb 27, 2017

jayvdb mentioned this pull request Feb 27, 2017

CheckstyleBear: Use checkstyle 6.19 #1462

Closed

gitmate-bot added the review carefully! label Feb 27, 2017

jayvdb force-pushed the checkstyle-7.6 branch from 04c1721 to 8bc4285 Compare March 2, 2017 17:32

coala-bot added process/wip and removed process/pending review labels Mar 22, 2017

jayvdb mentioned this pull request Mar 22, 2017

CheckstyleBear: Detect errors #1527

Merged

jayvdb mentioned this pull request Apr 5, 2017

CheckstyleBear: Upgrade checkstyle to 6.19 #1567

Merged

jayvdb force-pushed the checkstyle-7.6 branch from 8bc4285 to 4843a80 Compare April 23, 2017 11:46

gitmate-bot added process/pending review size/XS and removed process/wip size/S labels Apr 23, 2017

jayvdb force-pushed the checkstyle-7.6 branch from 4843a80 to d98f3a6 Compare April 24, 2017 13:49

gitmate-bot added size/S and removed size/XS labels Apr 24, 2017

jayvdb added 2 commits April 27, 2017 00:28

CheckstyleBear: Upgrade checkstyle 6.15 to 7.6

1f21869

Closes coala#1465

manual check

a204ccd

jayvdb force-pushed the checkstyle-7.6 branch from d98f3a6 to 834f839 Compare April 26, 2017 17:48

gitmate-bot reviewed Apr 26, 2017

View reviewed changes

Run checkstyle on command line

834f839

gitmate-bot added size/M and removed size/S labels Apr 26, 2017

gitmate-bot reviewed Apr 26, 2017

View reviewed changes

Use Java 1.8

9b7d2f5

gitmate-bot reviewed Apr 26, 2017

View reviewed changes

remove quotes

8d6affe

jayvdb mentioned this pull request Apr 26, 2017

Upgrade to checkstyle 7.6 #1675

Open

jayvdb added process/wip and removed process/pending review labels Apr 26, 2017

gitmate-bot added the status/STALE label Aug 31, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Checkstyle 7.6 #1466

Checkstyle 7.6 #1466

jayvdb commented Feb 27, 2017

gitmate-bot commented Mar 10, 2017

gitmate-bot commented Mar 17, 2017

sils commented Mar 22, 2017

sils commented Mar 22, 2017

jayvdb commented Mar 22, 2017

gitmate-bot commented Mar 29, 2017

gitmate-bot commented Apr 5, 2017

gitmate-bot commented Apr 12, 2017

gitmate-bot commented Apr 19, 2017

gitmate-bot Apr 26, 2017

gitmate-bot Apr 26, 2017

gitmate-bot Apr 26, 2017

jayvdb commented Apr 26, 2017

jayvdb commented Apr 26, 2017

gitmate-bot commented May 4, 2017

gitmate-bot commented May 11, 2017

gitmate-bot commented May 18, 2017

gitmate-bot commented May 18, 2017

gitmate-bot commented May 25, 2017

gitmate-bot commented Jun 1, 2017

gitmate-bot commented Jun 1, 2017

gitmate-bot commented Jun 8, 2017

gitmate-bot commented Jun 15, 2017

gitmate-bot commented Jun 21, 2017

gitmate-bot commented Jun 28, 2017

gitmate-bot commented Jul 5, 2017

gitmate-bot commented Jul 12, 2017

gitmate-bot commented Jul 20, 2017

Checkstyle 7.6 #1466

Are you sure you want to change the base?

Checkstyle 7.6 #1466

Conversation

jayvdb commented Feb 27, 2017

Checklist

gitmate-bot commented Mar 10, 2017

gitmate-bot commented Mar 17, 2017

sils commented Mar 22, 2017

sils commented Mar 22, 2017

jayvdb commented Mar 22, 2017

gitmate-bot commented Mar 29, 2017

gitmate-bot commented Apr 5, 2017

gitmate-bot commented Apr 12, 2017

gitmate-bot commented Apr 19, 2017

gitmate-bot Apr 26, 2017

Choose a reason for hiding this comment

gitmate-bot Apr 26, 2017

Choose a reason for hiding this comment

gitmate-bot Apr 26, 2017

Choose a reason for hiding this comment

jayvdb commented Apr 26, 2017

jayvdb commented Apr 26, 2017

gitmate-bot commented May 4, 2017

gitmate-bot commented May 11, 2017

gitmate-bot commented May 18, 2017

gitmate-bot commented May 18, 2017

gitmate-bot commented May 25, 2017

gitmate-bot commented Jun 1, 2017

gitmate-bot commented Jun 1, 2017

gitmate-bot commented Jun 8, 2017

gitmate-bot commented Jun 15, 2017

gitmate-bot commented Jun 21, 2017

gitmate-bot commented Jun 28, 2017

gitmate-bot commented Jul 5, 2017

gitmate-bot commented Jul 12, 2017

gitmate-bot commented Jul 20, 2017