Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Ruby gems in AppVeyor #1312

Merged
merged 2 commits into from
Dec 7, 2018
Merged

Install Ruby gems in AppVeyor #1312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53fac0b
Install Ruby gems in AppVeyor
rhemon Jan 16, 2017
f6119ad
.ci/appveyor.yml: Enable 100% coverage
jayvdb Dec 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .ci/appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@ environment:
- PYTHON: "C:\\Python34"
PYTHON_VERSION: "3.4.4"
PYTHON_ARCH: "32"
ruby_version: "22"

- PYTHON: "C:\\Python34-x64"
PYTHON_VERSION: "3.4.4"
PYTHON_ARCH: "64"
ruby_version: "22-x64"

cache:
- "C:\\pip_cache"
Expand Down Expand Up @@ -47,22 +49,28 @@ install:
- "npm config set loglevel warn"
- "npm install"

# Commands for Ruby
- sed -i '/ruby \'2\.2\.2\'/d' Gemfile
- "sed -i '/sqlint/d' Gemfile"
- "SET PATH=C:\\Ruby%ruby_version%\\bin;%PATH%"
- "bundle install"

build: false # Not a C# project, build stuff at the test step instead.

test_script:
# Force DOS format, as Checkstyle configs enable NewlineAtEndOfFile,
# which defaults to CRLF on Windows, and Appveyor CI ignores .gitattributes
# http://help.appveyor.com/discussions/problems/5687-gitattributes-changes-dont-have-any-effect
- unix2dos tests/java/test_files/CheckstyleGood.java
- sed -i '/fail_under/d' setup.cfg
# Clang DLLs x64 were nowadays installed, but the x64 version hangs, so we
# exclude according tests. See https://github.com/appveyor/ci/issues/495 and
# https://github.com/appveyor/ci/issues/688
- >
"%CMD_IN_ENV% python -m pytest
--cov -k "not ClangASTPrintBear and not ClangCloneDetectionBear and
not ClangComplexityBear and not ClangCountVectorCreator and
not ClangCountingConditions"
not ClangCountingConditions and not RuboCopBearTest and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Euhm, you can't install rubocop?

Copy link
Contributor Author

@rhemon rhemon Jun 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. it installs the gems but the tests fail for some reason in AppVeyor (link available above). same case for CSVLintBearTest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give us the logs when the tests fails?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pastebin.com/4tJcDQpB

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the Rubocop tests needs rework for Windows? It's harder to read without colors :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still wondering why csvlint just keeps returning blank

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about the problems myself and since not a windows user I am not sure if they are actually working fine in windows or not. maybe there should be separate issues for these two tests? and this PR moves on (ignoring the two tests for now) so that I can move on to #1288 😅

not CSVLintBearTest"
- "%CMD_IN_ENV% python setup.py install"
- "%CMD_IN_ENV% python -m pip install \
git+https://github.com/coala/coala"
Expand Down
2 changes: 1 addition & 1 deletion bears/configfiles/PuppetLintBear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
output_format='regex',
output_regex=r'(?P<line>\d+):(?P<column>\d+):'
r'(?P<severity>warning|error):(?P<message>.+)')
class PuppetLintBear: # pragma nt: no cover
class PuppetLintBear:
'''
Check and correct puppet configuration files using ``puppet-lint``.

Expand Down
2 changes: 1 addition & 1 deletion bears/haml/HAMLLintBear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
output_format='regex',
output_regex=r'(?P<line>\d+) \[(?P<severity>W|E)\] '
r'(?P<message>.*)')
class HAMLLintBear: # pragma nt: no cover
class HAMLLintBear:
"""
Uses ``haml-lint`` to perform HAML-specific style and lint checks to ensure
clean and readable HAML code.
Expand Down
2 changes: 1 addition & 1 deletion bears/ruby/RubySecurityBear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

@linter(executable='brakeman',
global_bear=True)
class RubySecurityBear: # pragma nt: no cover
class RubySecurityBear:
"""
Checks the Security issues of Ruby Applications.

Expand Down
2 changes: 1 addition & 1 deletion bears/ruby/RubySmellBear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@


@linter(executable='reek', use_stdin=True)
class RubySmellBear: # pragma nt: no cover
class RubySmellBear:
"""
Detect code smells in Ruby source code.

Expand Down
2 changes: 1 addition & 1 deletion bears/scss/SCSSLintBear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
output_regex=r'.+:(?P<line>\d+):(?P<column>\d+)\s+'
r'\[(?P<severity>.)\]\s+'
r'(?P<message>.*)')
class SCSSLintBear: # pragma nt: no cover
class SCSSLintBear:
"""
Check SCSS code to keep it clean and readable.

Expand Down
2 changes: 1 addition & 1 deletion bears/yaml/TravisLintBear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
@linter(executable='travis',
output_format='regex',
output_regex=r'\[x\]\s+(?P<message>.+)')
class TravisLintBear: # pragma nt: no cover
class TravisLintBear:
"""
A validator for your ``.travis.yml`` that attempts to reduce common build
errors such as:
Expand Down