Install Ruby gems in AppVeyor #1312

rhemon · 2017-01-16T04:59:36Z

Added commands to install ruby gems in appveyor
so that it can perform tests for the bears that
use ruby gems.

gitmate-bot · 2017-01-16T04:59:49Z

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

I have rebased properly. Please see this for a tutorial.
I have gone through the commit guidelines and I've followed them:
I have followed the guidelines for the commit shortlog.
I have followed the guidelines for the commit body.
I have included the issue URL.
I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

gitmate-bot · 2017-01-16T05:00:49Z

.ci/appveyor.yml

@@ -51,6 +54,12 @@ install:
  - "%CMD_IN_ENV% pip install --find-links=C:\\wheels -r test-requirements.txt"
  - "%CMD_IN_ENV% pip install --find-links=C:\\wheels -r requirements.txt"
  - "CALL .ci/deps.nltk.cmd"
+


Line contains following spacing inconsistencies:

Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section ci.

The issue can be fixed by applying the following patch:

--- a/.ci/appveyor.yml +++ b/.ci/appveyor.yml @@ -54,7 +54,7 @@ - "%CMD_IN_ENV% pip install --find-links=C:\\wheels -r test-requirements.txt" - "%CMD_IN_ENV% pip install --find-links=C:\\wheels -r requirements.txt" - "CALL .ci/deps.nltk.cmd" - + - sed -i '/ruby \'2\.2\.2\'/d' Gemfile - "sed -i '/sqlint/d' Gemfile" - "type Gemfile"

jayvdb · 2017-01-16T05:01:08Z

.ci/appveyor.yml

+
+  - sed -i '/ruby \'2\.2\.2\'/d' Gemfile
+  - "sed -i '/sqlint/d' Gemfile"
+  - "type Gemfile"


we dont need this line now

oh sorry, forgot to remove that

jayvdb · 2017-01-16T05:21:08Z

tests\ruby\RuboCopBearTest.py ssssss the tests are still being skipped because it cant find the binaries...hint hint.

rhemon · 2017-01-23T02:42:00Z

I need help in this, I installed gems with command bundle install --path=vendor\\bundle --verbose. And then added the bin dir with .BAT files to PATH with this command SET PATH=C:\\projects\\coala-bears\\vendor\\bundle\\ruby\\2.2.0\\bin;%PATH%. so after this some of the tests started to fail. Here is the log Without the command to add bin dir to PATH, tests get skipped and the build is green. I am sorry but I am not understanding the problem here. Full code here.

yukiisbored · 2017-01-26T00:28:12Z

@rhemon You can try by echo-ing the PATH variable and list the directories to see what's going on. It's a shame that Appveyor doesn't have an easy way to debug CI issues like this.

rhemon · 2017-01-26T03:07:31Z

@yukiisbored yup have tried that. as far as i can see PATH is fine. and have also listed the files in dir and saw it had .bat files. i am wondering if appveyor have problems with .bat?

yukiisbored · 2017-01-26T10:35:44Z

@rhemon I'm not quite sure, I'm not a Windows user by any means. I think the appveyor script on coala/coala runs an external batch script.

rhemon · 2017-01-27T14:57:41Z

cant understand the reason for tests failing for the bears with ruby gems here https://ci.appveyor.com/project/rhemon/coala-bears/build/1.0.156/job/n57e6dewq7hc9sbk
previously when I had bundle install --path=vendor/bundle and even after adding the dir with .bat files in PATH it didn't run the gem properly . i tried testing it by running a gem - https://ci.appveyor.com/project/rhemon/coala-bears/build/1.0.154/job/oj2lr0auwleu8b2b#L1165.
later following another repo i just tried bundle install and i was able to successfully run the gem https://ci.appveyor.com/project/rhemon/coala-bears/build/1.0.156/job/n57e6dewq7hc9sbk#L612 but tests are still failing. Here is the present appveyor.yml file
and you can ignore the InvalidLinkBearTest fail.
so if anyone knows what I have done wrong, please help me fix it.

gitmate-bot · 2017-02-03T18:26:17Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-02-03T18:26:17Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-02-11T04:12:32Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

rhemon · 2017-02-13T04:12:50Z

Managed to get some bear tests that use ruby gems to pass by adding .BAT since coala wasn't finding .bat files (which is solved right now, so I will undo those changes)
I still have RuboCopBearTest and CSVLintBearTest failing.
For CSVLintBear its yielding no result where it should, also getting AssertionError: list index out of range
For RuboCopBearTest its yielding a result, but it shouldn't. also getting AssertionError: Bear returned None on execution
I am not clear about this test fails and how I should be dealing with it.

gitmate-bot · 2017-02-20T10:26:20Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

nemani · 2017-02-26T10:38:09Z

Marking WIP because the tests are failing.
You should ask your doubts on Gitter. :)

gitmate-bot · 2017-03-05T20:39:56Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-03-13T06:26:47Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

yukiisbored · 2017-06-25T06:10:35Z

.ci/appveyor.yml

@@ -63,7 +71,8 @@ test_script:
    "%CMD_IN_ENV% python -m pytest
    --cov -k "not ClangASTPrintBear and not ClangCloneDetectionBear and
    not ClangComplexityBear and not ClangCountVectorCreator and
-    not ClangCountingConditions"
+    not ClangCountingConditions and not RuboCopBearTest and


Euhm, you can't install rubocop?

no. it installs the gems but the tests fail for some reason in AppVeyor (link available above). same case for CSVLintBearTest

Can you give us the logs when the tests fails?

https://pastebin.com/4tJcDQpB

It looks like the Rubocop tests needs rework for Windows? It's harder to read without colors :/

Still wondering why csvlint just keeps returning blank

not sure about the problems myself and since not a windows user I am not sure if they are actually working fine in windows or not. maybe there should be separate issues for these two tests? and this PR moves on (ignoring the two tests for now) so that I can move on to #1288 😅

sils · 2017-06-30T18:06:19Z

marking WIP because there are open discussions and failing builds

gitmate-bot · 2017-07-11T10:23:58Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-07-18T09:04:15Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-07-18T09:04:15Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

rhemon · 2017-08-19T06:59:21Z

@jayvdb so what can I do for this? there is still #1288

Added commands to install ruby gems in appveyor so that it can perform tests for the bears that use ruby gems. Closes coala#1305

jayvdb · 2018-12-07T15:56:53Z

ack 53fac0b f6119ad

jayvdb · 2018-12-07T15:58:48Z

@gitmate-bot ff

gitmate-bot · 2018-12-07T15:58:51Z

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

gitmate-bot · 2018-12-07T15:59:46Z

Automated fastforward with GitMate.io was successful! 🎉

gitmate-bot added process/pending review size/XS labels Jan 16, 2017

gitmate-bot reviewed Jan 16, 2017

View reviewed changes

jayvdb reviewed Jan 16, 2017

View reviewed changes

rhemon force-pushed the ruby-appveyor branch from 4cc209a to 5ba2a74 Compare January 16, 2017 05:02

jayvdb added process/wip and removed process/pending review labels Jan 16, 2017

rhemon mentioned this pull request Jan 29, 2017

WIP ImageDimensionBear: Add ImageDimensionBear to coala-bears #1288

Open

rhemon force-pushed the ruby-appveyor branch from 5ba2a74 to 8c5c0fa Compare February 13, 2017 03:42

gitmate-bot added process/pending review size/L and removed process/wip size/XS labels Feb 13, 2017

coala-bot added process/wip and removed process/pending review labels Feb 26, 2017

yukiisbored reviewed Jun 25, 2017

View reviewed changes

co-robo added process/wip and removed process/pending review labels Jun 30, 2017

gitmate-bot added the status/STALE label Aug 31, 2017

rhemon force-pushed the ruby-appveyor branch from c5914d2 to c597335 Compare September 14, 2017 17:16

gitmate-bot added process/pending review difficulty/low importance/medium labels Sep 14, 2017

gitmate-bot assigned rhemon Sep 14, 2017

gitmate-bot removed the status/STALE label Sep 14, 2017

gitmate-bot added the status/STALE label Sep 22, 2017

sils removed the process/wip label Oct 27, 2017

co-robo added process/wip and removed process/pending review labels Nov 13, 2017

gitmate-bot removed the status/STALE label Mar 30, 2018

rhemon and others added 2 commits December 7, 2018 20:01

Install Ruby gems in AppVeyor

53fac0b

Added commands to install ruby gems in appveyor so that it can perform tests for the bears that use ruby gems. Closes coala#1305

.ci/appveyor.yml: Enable 100% coverage

f6119ad

jayvdb force-pushed the ruby-appveyor branch from c597335 to f6119ad Compare December 7, 2018 15:28

gitmate-bot added process/pending review and removed process/wip labels Dec 7, 2018

gitmate-bot merged commit f6119ad into coala:master Dec 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Install Ruby gems in AppVeyor #1312

Install Ruby gems in AppVeyor #1312

rhemon commented Jan 16, 2017

gitmate-bot commented Jan 16, 2017

gitmate-bot Jan 16, 2017

jayvdb Jan 16, 2017

rhemon Jan 16, 2017

jayvdb commented Jan 16, 2017

rhemon commented Jan 23, 2017 •

edited

Loading

yukiisbored commented Jan 26, 2017 •

edited

Loading

rhemon commented Jan 26, 2017

yukiisbored commented Jan 26, 2017

rhemon commented Jan 27, 2017 •

edited

Loading

gitmate-bot commented Feb 3, 2017

gitmate-bot commented Feb 3, 2017

gitmate-bot commented Feb 11, 2017

rhemon commented Feb 13, 2017

gitmate-bot commented Feb 20, 2017

nemani commented Feb 26, 2017

gitmate-bot commented Mar 5, 2017

gitmate-bot commented Mar 13, 2017

yukiisbored Jun 25, 2017

rhemon Jun 25, 2017 •

edited

Loading

yukiisbored Jun 26, 2017

rhemon Jun 26, 2017

yukiisbored Jul 2, 2017

yukiisbored Jul 2, 2017

rhemon Jul 3, 2017

sils commented Jun 30, 2017

gitmate-bot commented Jul 11, 2017

gitmate-bot commented Jul 18, 2017

gitmate-bot commented Jul 18, 2017

rhemon commented Aug 19, 2017

jayvdb commented Dec 7, 2018

jayvdb commented Dec 7, 2018

gitmate-bot commented Dec 7, 2018

gitmate-bot commented Dec 7, 2018

Install Ruby gems in AppVeyor #1312

Install Ruby gems in AppVeyor #1312

Conversation

rhemon commented Jan 16, 2017

gitmate-bot commented Jan 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayvdb commented Jan 16, 2017

rhemon commented Jan 23, 2017 • edited Loading

yukiisbored commented Jan 26, 2017 • edited Loading

rhemon commented Jan 26, 2017

yukiisbored commented Jan 26, 2017

rhemon commented Jan 27, 2017 • edited Loading

gitmate-bot commented Feb 3, 2017

gitmate-bot commented Feb 3, 2017

gitmate-bot commented Feb 11, 2017

rhemon commented Feb 13, 2017

gitmate-bot commented Feb 20, 2017

nemani commented Feb 26, 2017

gitmate-bot commented Mar 5, 2017

gitmate-bot commented Mar 13, 2017

Choose a reason for hiding this comment

rhemon Jun 25, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sils commented Jun 30, 2017

gitmate-bot commented Jul 11, 2017

gitmate-bot commented Jul 18, 2017

gitmate-bot commented Jul 18, 2017

rhemon commented Aug 19, 2017

jayvdb commented Dec 7, 2018

jayvdb commented Dec 7, 2018

gitmate-bot commented Dec 7, 2018

gitmate-bot commented Dec 7, 2018

rhemon commented Jan 23, 2017 •

edited

Loading

yukiisbored commented Jan 26, 2017 •

edited

Loading

rhemon commented Jan 27, 2017 •

edited

Loading

rhemon Jun 25, 2017 •

edited

Loading