WIP bears/general: Add CheckmanifestBear #1067

aptrishu · 2016-11-27T16:16:35Z

Adds CheckmanifestBear for https://pypi.python.org/pypi/check-manifest
to check MANIFEST.in for completeness.

Closes #798

gitmate-bot · 2016-11-27T16:16:48Z

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

I have rebased properly. Please see this for a tutorial.
I have gone through the commit guidelines and I've followed them:
I have followed the guidelines for the commit shortlog.
I have followed the guidelines for the commit body.
I have included the issue URL.
I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

gitmate-bot · 2016-11-27T16:42:45Z

tests/general/CheckmanifestBearTest.py

+                          'MANIFEST.in')),
+            invalid_files=(),
+            settings={"ignore":
+                      "unrelated.txt","create":"True","update":"True"})


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -40,7 +40,7 @@ 'MANIFEST.in')), invalid_files=(), settings={"ignore": - "unrelated.txt","create":"True","update":"True"}) + "unrelated.txt", "create": "True", "update": "True"}) # Stop ignoring if __name__ == '__main__':

gitmate-bot · 2016-11-27T22:03:26Z

tests/general/CheckmanifestBearTest.py

+            invalid_files=(path.join(self.testt_dir, 'MANIFEST.in')),
+            settings={'ignore':
+                      'unrelated.txt', 'create': 'True', 'update': 'True'})
+


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -74,4 +74,3 @@ invalid_files=(path.join(self.testt_dir, 'MANIFEST.in')), settings={'ignore': 'unrelated.txt', 'create': 'True', 'update': 'True'}) -

gitmate-bot · 2016-11-27T22:03:27Z

tests/general/CheckmanifestBearTest.py

+            invalid_files=(path.join(self.test_dir,
+                                     'MANIFEST.in')))
+
+


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -57,7 +57,6 @@ invalid_files=(path.join(self.test_dir, 'MANIFEST.in'))) - self.file_dict = {path.join(self.testt_dir, 'MANIFEST.in'): ""} self.assertEqual(self.run_uut(), [])

gitmate-bot · 2016-11-27T22:57:38Z

tests/general/CheckmanifestBearTest.py

+        self.queue = Queue()
+        self.file_dict = {}
+        self.section = Section('test')
+        self.section.add_or_create_setting(Setting('ignore','unrelated.txt'))


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -19,7 +19,7 @@ self.queue = Queue() self.file_dict = {} self.section = Section('test') - self.section.add_or_create_setting(Setting('ignore','unrelated.txt')) + self.section.add_or_create_setting(Setting('ignore', 'unrelated.txt')) self.uut = CheckmanifestBear(self.file_dict, self.section, self.queue)

meetmangukiya · 2016-11-28T08:10:15Z

tests/general/CheckmanifestBearTest.py

+        self.queue = Queue()
+        self.file_dict = {}
+        self.section = Section('test')
+        self.section.add_or_create_setting(Setting('ignore', 'unrelated.txt'))


I have a workaround...
Remove this line

meetmangukiya · 2016-11-28T08:10:54Z

tests/general/CheckmanifestBearTest.py

+        shutil.rmtree(self.testt_dir)
+
+    def run_uut(self, *args, **kwargs):
+        return list(result.message for result in self.uut.run())


change to return list(result.message for result in self.uut.run(*args, **kwargs))

meetmangukiya · 2016-11-28T08:12:10Z

tests/general/CheckmanifestBearTest.py

+
+        self.file_dict = {path.join(self.testt_dir, 'MANIFEST.in'):
+                          ""}
+        self.assertEqual(self.run_uut(), [])


change to self.assertEqual(self.run_uut(ignore = ['unrelated.txt']), [])

Also run coala.. anotation bear has some issues

meetmangukiya · 2016-11-28T08:13:42Z

You see what I did here, @aptrishu 😉

gitmate-bot · 2017-02-02T20:12:37Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-02-02T20:12:38Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

jayvdb

Try running it without coverage.
Also write a note explaining what you have tried so far.

jayvdb · 2016-12-18T14:29:50Z

tests/general/CheckmanifestBearTest.py

+            f.write('# wow. such code. so amaze\n')
+            f.close()
+
+        f = open(path.join(self.test_dir, 'MANIFEST.in'), 'w')


use with for these.

jayvdb · 2016-12-18T14:30:13Z

tests/general/CheckmanifestBearTest.py

+        f.write('Hello from the other side')
+        f.close()
+        f = open(path.join(self.test_dir, 'rishu.cpp'), 'w')
+        f.write('int main')


ouch this burns. Please make it a valid .cpp file.

ghost · 2017-02-09T05:34:31Z

tests/general/CheckmanifestBearTest.py

+        self.uut.file_dict = {path.join(self.test_dir, 'MANIFEST.in'):
+                              ''}
+        self.assertEqual(self.run_uut(ignore=['unrelated.txt', 'rishu.cpp']),
+                         ['lists of files in version control and sdist match!'])  # Ignore LineLengthBear


Why are you ignoring LineLengthBear ?? you can split this line into two... 😄

formatting is not the concern right now.. You can see

PR is marked WIP -> its not ready.

coverage is creating problems with CI (upstream problem).

gitmate-bot · 2017-02-10T05:59:26Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-02-17T15:46:19Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-02-25T01:33:06Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-03-04T11:19:41Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-03-11T21:06:52Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-03-19T06:53:19Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-03-26T05:33:22Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-04-02T04:13:44Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-04-09T02:53:25Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-04-16T01:33:25Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-04-23T00:13:51Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-04-29T22:53:43Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-05-06T21:34:13Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-05-14T13:30:12Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-05-21T12:10:08Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-05-28T21:57:08Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-05-28T21:57:08Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-06-04T20:37:04Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-06-11T19:17:10Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-06-19T05:03:54Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-06-26T14:51:38Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-07-03T13:30:47Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-07-11T10:24:00Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-07-18T09:04:04Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot added process/wip size/M labels Nov 27, 2016

aptrishu force-pushed the new798 branch 2 times, most recently from f6d0b48 to ed13f26 Compare November 27, 2016 16:42

gitmate-bot reviewed Nov 27, 2016

View reviewed changes

aptrishu force-pushed the new798 branch 6 times, most recently from ce658f8 to a558461 Compare November 27, 2016 20:47

gitmate-bot added size/L and removed size/M labels Nov 27, 2016

aptrishu force-pushed the new798 branch from a558461 to 6c2a4a0 Compare November 27, 2016 22:02

gitmate-bot reviewed Nov 27, 2016

View reviewed changes

aptrishu force-pushed the new798 branch 6 times, most recently from 4bfb1d0 to 2ac3dd1 Compare November 27, 2016 22:57

gitmate-bot reviewed Nov 27, 2016

View reviewed changes

aptrishu force-pushed the new798 branch from 2ac3dd1 to 0c0aa0f Compare November 27, 2016 22:59

meetmangukiya reviewed Nov 28, 2016

View reviewed changes

aptrishu force-pushed the new798 branch 3 times, most recently from 31a6c57 to f29073a Compare November 28, 2016 11:04

jayvdb requested changes Feb 8, 2017

View reviewed changes

ghost reviewed Feb 9, 2017

View reviewed changes

jayvdb mentioned this pull request Apr 28, 2017

bears/general: Add CheckmanifestBear #1066

Closed

gitmate-bot added the status/STALE label Aug 31, 2017

WIP bears/general: Add CheckmanifestBear #1067

Are you sure you want to change the base?

WIP bears/general: Add CheckmanifestBear #1067

Conversation

aptrishu commented Nov 27, 2016

gitmate-bot commented Nov 27, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meetmangukiya commented Nov 28, 2016

gitmate-bot commented Feb 2, 2017

gitmate-bot commented Feb 2, 2017

jayvdb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitmate-bot commented Feb 10, 2017

gitmate-bot commented Feb 17, 2017

gitmate-bot commented Feb 25, 2017

gitmate-bot commented Mar 4, 2017

gitmate-bot commented Mar 11, 2017

gitmate-bot commented Mar 19, 2017

gitmate-bot commented Mar 26, 2017

gitmate-bot commented Apr 2, 2017

gitmate-bot commented Apr 9, 2017

gitmate-bot commented Apr 16, 2017

gitmate-bot commented Apr 23, 2017

gitmate-bot commented Apr 29, 2017

gitmate-bot commented May 6, 2017

gitmate-bot commented May 14, 2017

gitmate-bot commented May 21, 2017

gitmate-bot commented May 28, 2017

gitmate-bot commented May 28, 2017

gitmate-bot commented Jun 4, 2017

gitmate-bot commented Jun 11, 2017

gitmate-bot commented Jun 19, 2017

gitmate-bot commented Jun 26, 2017

gitmate-bot commented Jul 3, 2017

gitmate-bot commented Jul 11, 2017

gitmate-bot commented Jul 18, 2017