bears/general: Add CheckmanifestBear #1066

aptrishu · 2016-11-27T15:22:36Z

Adds CheckmanifestBear for https://pypi.python.org/pypi/check-manifest
to check MANIFEST.in for completeness.

Closes #798

gitmate-bot · 2016-11-27T15:22:49Z

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

I have rebased properly. Please see this for a tutorial.
I have gone through the commit guidelines and I've followed them:
I have followed the guidelines for the commit shortlog.
I have followed the guidelines for the commit body.
I have included the issue URL.
I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

gitmate-bot · 2016-11-27T15:23:04Z

tests/general/CheckmanifestBearTest.py

+			settings={"ignore": "unrelated.txt"})
+
+if __name__ == '__main__':
+    unittest.main


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -28,4 +28,4 @@ settings={"ignore": "unrelated.txt"}) if __name__ == '__main__': - unittest.main+ unittest.main

gitmate-bot · 2016-11-27T15:23:04Z

tests/general/CheckmanifestBearTest.py

+
+from bears.general.CheckmanifestBear import CheckmanifestBear
+from tests.LocalBearTestHelper import verify_local_bear
+


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -5,7 +5,9 @@ from bears.general.CheckmanifestBear import CheckmanifestBear from tests.LocalBearTestHelper import verify_local_bear + class TestExample(unittest.TestCase): + def setUp(self): self.test_dir = tempfile.mkdtemp()

gitmate-bot · 2016-11-27T15:23:05Z

tests/general/CheckmanifestBearTest.py

@@ -0,0 +1,31 @@
+import shutil, tempfile


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -1,4 +1,5 @@ -import shutil, tempfile +import shutil +import tempfile from os import path import unittest

gitmate-bot · 2016-11-27T15:23:06Z

bears/general/CheckmanifestBear.py

+            extra += '-u '
+        args = ()
+        if ignore:
+          args = (extra + '--ignore=' +


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/general/CheckmanifestBear.py +++ b/bears/general/CheckmanifestBear.py @@ -41,6 +41,6 @@ extra += '-u ' args = () if ignore: - args = (extra + '--ignore=' + - ','.join(ignore),) + args = (extra + '--ignore=' + + ','.join(ignore),) return args + (os.path.dirname(filename),)

gitmate-bot · 2016-11-27T15:23:06Z

tests/general/CheckmanifestBearTest.py

+			settings={"ignore": "unrelated.txt"})
+
+if __name__ == '__main__':
+    unittest.main


Line contains following spacing inconsistencies:

No newline at EOF.

SpaceConsistencyBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -28,4 +28,4 @@ settings={"ignore": "unrelated.txt"}) if __name__ == '__main__': - unittest.main+ unittest.main

gitmate-bot · 2016-11-27T15:23:07Z

tests/general/CheckmanifestBearTest.py

+			invalid_files=(path.join(self.test_dir, 'MANIFEST.in')))
+		CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,
+			valid_files=(path.join(self.test_dir, 'MANIFEST.in')),
+			settings={"ignore": "unrelated.txt"})


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

SpaceConsistencyBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -25,7 +25,7 @@ invalid_files=(path.join(self.test_dir, 'MANIFEST.in'))) CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, valid_files=(path.join(self.test_dir, 'MANIFEST.in')), - settings={"ignore": "unrelated.txt"}) + settings={"ignore": "unrelated.txt"}) if __name__ == '__main__': unittest.main```

gitmate-bot · 2016-11-27T15:23:07Z

tests/general/CheckmanifestBearTest.py

+		CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,
+			invalid_files=(path.join(self.test_dir, 'MANIFEST.in')))
+		CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,
+			valid_files=(path.join(self.test_dir, 'MANIFEST.in')),


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

SpaceConsistencyBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -24,7 +24,7 @@ CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, invalid_files=(path.join(self.test_dir, 'MANIFEST.in'))) CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, - valid_files=(path.join(self.test_dir, 'MANIFEST.in')), + valid_files=(path.join(self.test_dir, 'MANIFEST.in')), settings={"ignore": "unrelated.txt"}) if __name__ == '__main__':

gitmate-bot · 2016-11-27T15:23:08Z

tests/general/CheckmanifestBearTest.py

+		f.write('Hello from the other side')
+		CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,
+			invalid_files=(path.join(self.test_dir, 'MANIFEST.in')))
+		CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

SpaceConsistencyBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -23,7 +23,7 @@ f.write('Hello from the other side') CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, invalid_files=(path.join(self.test_dir, 'MANIFEST.in'))) - CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, + CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, valid_files=(path.join(self.test_dir, 'MANIFEST.in')), settings={"ignore": "unrelated.txt"})

gitmate-bot · 2016-11-27T15:23:08Z

tests/general/CheckmanifestBearTest.py

+		f = open(path.join(self.test_dir, 'unrelated.txt'), 'w')
+		f.write('Hello from the other side')
+		CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,
+			invalid_files=(path.join(self.test_dir, 'MANIFEST.in')))


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

SpaceConsistencyBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -22,7 +22,7 @@ f = open(path.join(self.test_dir, 'unrelated.txt'), 'w') f.write('Hello from the other side') CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, - invalid_files=(path.join(self.test_dir, 'MANIFEST.in'))) + invalid_files=(path.join(self.test_dir, 'MANIFEST.in'))) CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, valid_files=(path.join(self.test_dir, 'MANIFEST.in')), settings={"ignore": "unrelated.txt"})

gitmate-bot · 2016-11-27T15:23:09Z

tests/general/CheckmanifestBearTest.py

+		f = open(path.join(self.test_dir, 'MANIFEST.in'), 'w')
+		f = open(path.join(self.test_dir, 'unrelated.txt'), 'w')
+		f.write('Hello from the other side')
+		CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

SpaceConsistencyBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -21,7 +21,7 @@ f = open(path.join(self.test_dir, 'MANIFEST.in'), 'w') f = open(path.join(self.test_dir, 'unrelated.txt'), 'w') f.write('Hello from the other side') - CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, + CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, invalid_files=(path.join(self.test_dir, 'MANIFEST.in'))) CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, valid_files=(path.join(self.test_dir, 'MANIFEST.in')),

gitmate-bot · 2016-11-27T15:23:10Z

tests/general/CheckmanifestBearTest.py

+			f.write("# wow. such code. so amaze\n")
+		f = open(path.join(self.test_dir, 'MANIFEST.in'), 'w')
+		f = open(path.join(self.test_dir, 'unrelated.txt'), 'w')
+		f.write('Hello from the other side')


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

SpaceConsistencyBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -20,7 +20,7 @@ f.write("# wow. such code. so amaze\n") f = open(path.join(self.test_dir, 'MANIFEST.in'), 'w') f = open(path.join(self.test_dir, 'unrelated.txt'), 'w') - f.write('Hello from the other side') + f.write('Hello from the other side') CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, invalid_files=(path.join(self.test_dir, 'MANIFEST.in'))) CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,

gitmate-bot · 2016-11-27T15:23:10Z

tests/general/CheckmanifestBearTest.py

+        with open(path.join(self.test_dir, 'sample.py'), 'w') as f:
+			f.write("# wow. such code. so amaze\n")
+		f = open(path.join(self.test_dir, 'MANIFEST.in'), 'w')
+		f = open(path.join(self.test_dir, 'unrelated.txt'), 'w')


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

SpaceConsistencyBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -19,7 +19,7 @@ with open(path.join(self.test_dir, 'sample.py'), 'w') as f: f.write("# wow. such code. so amaze\n") f = open(path.join(self.test_dir, 'MANIFEST.in'), 'w') - f = open(path.join(self.test_dir, 'unrelated.txt'), 'w') + f = open(path.join(self.test_dir, 'unrelated.txt'), 'w') f.write('Hello from the other side') CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, invalid_files=(path.join(self.test_dir, 'MANIFEST.in')))

gitmate-bot · 2016-11-27T15:23:11Z

tests/general/CheckmanifestBearTest.py

+            f.write("setup(name='sample', py_modules=['sample'])\n")
+        with open(path.join(self.test_dir, 'sample.py'), 'w') as f:
+			f.write("# wow. such code. so amaze\n")
+		f = open(path.join(self.test_dir, 'MANIFEST.in'), 'w')


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

SpaceConsistencyBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -18,7 +18,7 @@ f.write("setup(name='sample', py_modules=['sample'])\n") with open(path.join(self.test_dir, 'sample.py'), 'w') as f: f.write("# wow. such code. so amaze\n") - f = open(path.join(self.test_dir, 'MANIFEST.in'), 'w') + f = open(path.join(self.test_dir, 'MANIFEST.in'), 'w') f = open(path.join(self.test_dir, 'unrelated.txt'), 'w') f.write('Hello from the other side') CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,

gitmate-bot · 2016-11-27T15:23:11Z

tests/general/CheckmanifestBearTest.py

+            f.write("from setuptools import setup\n")
+            f.write("setup(name='sample', py_modules=['sample'])\n")
+        with open(path.join(self.test_dir, 'sample.py'), 'w') as f:
+			f.write("# wow. such code. so amaze\n")


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

SpaceConsistencyBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -17,7 +17,7 @@ f.write("from setuptools import setup\n") f.write("setup(name='sample', py_modules=['sample'])\n") with open(path.join(self.test_dir, 'sample.py'), 'w') as f: - f.write("# wow. such code. so amaze\n") + f.write("# wow. such code. so amaze\n") f = open(path.join(self.test_dir, 'MANIFEST.in'), 'w') f = open(path.join(self.test_dir, 'unrelated.txt'), 'w') f.write('Hello from the other side')

gitmate-bot · 2016-11-27T15:23:12Z

bears/general/CheckmanifestBear.py

+
+    @staticmethod
+    def create_arguments(filename, file, config_file,
+                         create: bool=False, update: bool=False, ignore: list=None):


Line is longer than allowed. (84 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:26:30Z

bears/general/CheckmanifestBear.py

+
+    @staticmethod
+    def create_arguments(filename, file, config_file,
+                         create: bool=False, update: bool=False, ignore: list=None):


Line is longer than allowed. (84 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:26:30Z

tests/general/CheckmanifestBearTest.py

+        f = open(path.join(self.test_dir, 'unrelated.txt'), 'w')
+        f.write('Hello from the other side')
+        CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,
+            invalid_files=(path.join(self.test_dir, 'MANIFEST.in')))


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/general/CheckmanifestBearTest.py +++ b/tests/general/CheckmanifestBearTest.py @@ -25,10 +25,11 @@ f = open(path.join(self.test_dir, 'unrelated.txt'), 'w') f.write('Hello from the other side') CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, - invalid_files=(path.join(self.test_dir, 'MANIFEST.in'))) + invalid_files=(path.join(self.test_dir, 'MANIFEST.in'))) CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear, - valid_files=(path.join(self.test_dir, 'MANIFEST.in')), - settings={"ignore": "unrelated.txt"}) + valid_files=( + path.join(self.test_dir, 'MANIFEST.in')), + settings={"ignore": "unrelated.txt"}) if __name__ == '__main__': unittest.main

gitmate-bot · 2016-11-27T15:34:50Z

tests/general/CheckmanifestBearTest.py

+        f.write('Hello from the other side')
+        CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,
+                                                             invalid_files=(path.join(self.test_dir,
+                                                                                      'MANIFEST.in')))


Line is longer than allowed. (102 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:34:50Z

tests/general/CheckmanifestBearTest.py

+        f = open(path.join(self.test_dir, 'unrelated.txt'), 'w')
+        f.write('Hello from the other side')
+        CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,
+                                                             invalid_files=(path.join(self.test_dir,


Line is longer than allowed. (100 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:34:51Z

bears/general/CheckmanifestBear.py

+
+    @staticmethod
+    def create_arguments(filename, file, config_file,
+                         create: bool=False, update: bool=False, ignore: list=None):


Line is longer than allowed. (84 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:40:14Z

bears/rest/CheckmanifestBear.py

+            extra += '-u '
+        args = ()
+        if ignore:
+          args = (extra + '--ignore=' +


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/rest/CheckmanifestBear.py +++ b/bears/rest/CheckmanifestBear.py @@ -41,6 +41,6 @@ extra += '-u ' args = () if ignore: - args = (extra + '--ignore=' + - ','.join(ignore),) + args = (extra + '--ignore=' + + ','.join(ignore),) return args + (os.path.dirname(filename),)

gitmate-bot · 2016-11-27T15:40:15Z

tests/general/CheckmanifestBearTest.py

+                                                                 path.join(self.test_dir,
+                                                                           'MANIFEST.in')),
+                                                             settings={"ignore":
+                                                                       "unrelated.txt"})


Line is longer than allowed. (88 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:40:15Z

tests/general/CheckmanifestBearTest.py

+                                                             valid_files=(
+                                                                 path.join(self.test_dir,
+                                                                           'MANIFEST.in')),
+                                                             settings={"ignore":


Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:40:16Z

tests/general/CheckmanifestBearTest.py

+        CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,
+                                                             valid_files=(
+                                                                 path.join(self.test_dir,
+                                                                           'MANIFEST.in')),


Line is longer than allowed. (91 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:40:16Z

tests/general/CheckmanifestBearTest.py

+                                                                                      'MANIFEST.in')))
+        CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,
+                                                             valid_files=(
+                                                                 path.join(self.test_dir,


Line is longer than allowed. (89 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:40:17Z

tests/general/CheckmanifestBearTest.py

+        # Ignore LineLengthBear
+        CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,
+                                                             invalid_files=(path.join(self.test_dir,
+                                                                                      'MANIFEST.in')))


Line is longer than allowed. (102 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:40:18Z

tests/general/CheckmanifestBearTest.py

+        f.write('Hello from the other side')
+        # Ignore LineLengthBear
+        CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,
+                                                             invalid_files=(path.join(self.test_dir,


Line is longer than allowed. (100 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:40:18Z

bears/general/CheckmanifestBear.py

+
+    @staticmethod
+    def create_arguments(filename, file, config_file,
+                         create: bool=False, update: bool=False, ignore: list=None):


Line is longer than allowed. (84 > 79)

LineLengthBear, severity NORMAL, section linelength.

Adds CheckmanifestBear for https://pypi.python.org/pypi/check-manifest to check MANIFEST.in for completeness. Closes coala#798

gitmate-bot · 2016-11-27T15:45:19Z

bears/rest/CheckmanifestBear.py

+            extra += '-u '
+        args = ()
+        if ignore:
+          args = (extra + '--ignore=' +


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/rest/CheckmanifestBear.py +++ b/bears/rest/CheckmanifestBear.py @@ -41,6 +41,6 @@ extra += '-u ' args = () if ignore: - args = (extra + '--ignore=' + - ','.join(ignore),) + args = (extra + '--ignore=' + + ','.join(ignore),) return args + (os.path.dirname(filename),)

gitmate-bot · 2016-11-27T15:45:20Z

tests/general/CheckmanifestBearTest.py

+                                                                 path.join(self.test_dir,
+                                                                           'MANIFEST.in')),
+                                                             settings={"ignore":
+                                                                       "unrelated.txt"})


Line is longer than allowed. (88 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:45:21Z

tests/general/CheckmanifestBearTest.py

+                                                             valid_files=(
+                                                                 path.join(self.test_dir,
+                                                                           'MANIFEST.in')),
+                                                             settings={"ignore":


Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:45:21Z

tests/general/CheckmanifestBearTest.py

+        CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,
+                                                             valid_files=(
+                                                                 path.join(self.test_dir,
+                                                                           'MANIFEST.in')),


Line is longer than allowed. (91 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:45:22Z

tests/general/CheckmanifestBearTest.py

+                                     'MANIFEST.in')))
+        CheckmanifestBearTest_suggestion = verify_local_bear(CheckmanifestBear,
+                                                             valid_files=(
+                                                                 path.join(self.test_dir,


Line is longer than allowed. (89 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-27T15:45:22Z

bears/general/CheckmanifestBear.py

+
+    @staticmethod
+    def create_arguments(filename, file, config_file,
+                         create: bool=False, update: bool=False, ignore: list=None):


Line is longer than allowed. (84 > 79)

LineLengthBear, severity NORMAL, section linelength.

jayvdb · 2017-04-28T08:37:52Z

Work continues at #1067

gitmate-bot added process/pending review size/M review carefully! labels Nov 27, 2016

aptrishu added process/wip and removed process/pending review review carefully! size/M labels Nov 27, 2016

gitmate-bot reviewed Nov 27, 2016

View reviewed changes

aptrishu force-pushed the issue798 branch from 236e390 to 86bb73c Compare November 27, 2016 15:26

gitmate-bot added process/pending review size/M review carefully! and removed process/wip labels Nov 27, 2016

gitmate-bot reviewed Nov 27, 2016

View reviewed changes

aptrishu force-pushed the issue798 branch from dd873ac to bd79292 Compare November 27, 2016 15:39

gitmate-bot added process/pending review and removed process/wip labels Nov 27, 2016

gitmate-bot reviewed Nov 27, 2016

View reviewed changes

aptrishu added process/wip and removed process/pending review labels Nov 27, 2016

gitmate-bot reviewed Nov 27, 2016

View reviewed changes

bears/general: Add CheckmanifestBear

7d69e47

Adds CheckmanifestBear for https://pypi.python.org/pypi/check-manifest to check MANIFEST.in for completeness. Closes coala#798

aptrishu force-pushed the issue798 branch from bd79292 to 7d69e47 Compare November 27, 2016 15:44

gitmate-bot added process/pending review and removed process/wip labels Nov 27, 2016

gitmate-bot reviewed Nov 27, 2016

View reviewed changes

aptrishu added process/wip and removed process/pending review labels Nov 27, 2016

aptrishu closed this Nov 27, 2016


		from bears.general.CheckmanifestBear import CheckmanifestBear
		from tests.LocalBearTestHelper import verify_local_bear

bears/general: Add CheckmanifestBear #1066

bears/general: Add CheckmanifestBear #1066

Conversation

aptrishu commented Nov 27, 2016

gitmate-bot commented Nov 27, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayvdb commented Apr 28, 2017