-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for recent Rust version #5
base: master
Are you sure you want to change the base?
Conversation
Thank you man! |
Great, so... can this be merged? |
Sorry to bug you, @cnwzhjs but would you mind having a look in case this can be merged? (And published on crates.io)? |
Or @Katletos |
I am not a maintainer of this repository |
But thanks again for your changes, they have helped me a lot |
@cnwzhjs I would love to have this repository available for installation via crates.io (also so that I can publish other projects which depend on it). Any chance of bringing this project up to date with this Pull Request and publishing it on crates.io? Or, would you like to give ownership over the project to someone else? Or let someone else publish this on crates.io ? |
Oh, I see it is published on https://crates.io/crates/rplidar_drv Then I guess I would like to know whether it can be updated so I can install the newer version from other projects? |
@anselanza it might be best to publish your forked version on crates.io. Not sure what'd be best naming-wise ( |
OK, done. It's a little messy now (I had to include the Visit https://crates.io/crates/rplidar_drv_rs |
@anselanza maybe the PR should be left open in case the repo owner comes back. It'd also offer some better discoverability for people trying to find an updated version. Thank you for publishing it! Have a happy holidays 🥳 |
Good idea, reopened for now. |
This Pull Request attempts to leave the basic crate structure the same (
rpos_drv
is still a separate crate) while making some adjustments to get up to date with later Rust compiler versions.