Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "cel: Add canonical CEL (dev.cel.expr) fields"" #81

Closed

Commits on Jan 24, 2024

  1. Revert "Revert "Add canonical CEL support: dev.cel.expr (cncf#75)" (c…

    …ncf#79)"
    
    This reverts commit 5b9bca5.
    
    Reverts cncf#79.
    Now that cncf#78 `go build` CI is in place; this PR brings back the
    CEL fields.
    
    Once `del.dev` domain is fixed, we'll see the CI passing and will be
    able to merge this PR.
    
    Original comment
    
    Signed-off-by: Sergii Tkachenko <[email protected]>
    ---
    
    This PR adds canonical CEL
    (https://github.com/google/cel-spec/tree/master/proto/cel/expr) fields
    to `xds.type.v3.CelExpression`. Canonical CEL `cel.expr` was created
    identical to the `google.api.expr.v1alpha1`, but may be extended in a
    backward-compatible way.
    
    Nuances: 1. The new fields `cel_expr_parsed` and `cel_expr_checked` are
    added outside of `oneof expr_specifier` per updated policy change:
    envoyproxy/envoy#30851 2. `option
    (validate.required) = true` is removed from the `oneof expr_specifier`,
    so the users may not presume one of the `parsed_expr`, `checked_expr`
    will be set.
    
    ---
    
    Signed-off-by: Sergii Tkachenko <[email protected]>
    sergiitk committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    7ff31d7 View commit details
    Browse the repository at this point in the history
  2. Add cel.dev/expr to go.mod

    Signed-off-by: Sergii Tkachenko <[email protected]>
    sergiitk committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    205f35c View commit details
    Browse the repository at this point in the history