Revert "Revert "cel: Add canonical CEL (dev.cel.expr) fields"" #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #79.
Now that #78
go build
CI is in place; this PR brings back the CEL fields.Once
del.dev
domain is fixed, we'll see the CI passing and will be able to merge this PR.Ref #76.
Original comment
This PR adds canonical CEL (https://github.com/google/cel-spec/tree/master/proto/cel/expr) fields to
xds.type.v3.CelExpression
. Canonical CELcel.expr
was created identical to thegoogle.api.expr.v1alpha1
, but may be extended in a backward-compatible way.Nuances:
cel_expr_parsed
andcel_expr_checked
are added outside ofoneof expr_specifier
per updated policy change: API: change style guide to discourage use of "oneof" envoyproxy/envoy#30851option (validate.required) = true
is removed from theoneof expr_specifier
, so the users may not presume one of theparsed_expr
,checked_expr
will be set.