Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for showing blank issues in issue template chooser #588

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

aliok
Copy link
Member

@aliok aliok commented Jan 25, 2024

Fixes #587

See #587 about the problem.

This PR tries to address that problem by using GitHub's contact links feature.

If this is merged, the issue page (https://github.com/cncf/tag-contributor-strategy/issues/new/choose) will look similar to this:

Screenshot 2024-01-25 at 09 56 46

@aliok
Copy link
Member Author

aliok commented Jan 25, 2024

/hold

Hold until review from CNCF folks in #587 (maybe they have a better idea)

@aliok aliok marked this pull request as draft January 25, 2024 06:58
@riaankleinhans
Copy link
Contributor

No, don't know of a better plan. I like your solution.

@aliok aliok force-pushed the 2024-01-25-blank-issue-workaround branch from 3f8e461 to f54f1c5 Compare February 2, 2024 07:12
@aliok aliok force-pushed the 2024-01-25-blank-issue-workaround branch from f54f1c5 to 67a70b8 Compare February 6, 2024 22:07
@aliok aliok marked this pull request as ready for review February 6, 2024 22:08
@aliok
Copy link
Member Author

aliok commented Feb 6, 2024

Based on Riaan's (above) and Chris's comment (#587 (comment)), I am merging this one. I didn't receive anything from GitHub folks either.

@aliok aliok merged commit b1fd7c8 into cncf:main Feb 6, 2024
2 checks passed
@aliok aliok deleted the 2024-01-25-blank-issue-workaround branch February 6, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Users get confused when creating issues
2 participants