Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit SimHitCollection copy-constructor #44602

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

iarspider
Copy link
Contributor

PR description:

Clang emits a warning:

  .../src/DataFormats/HGCalDigi/interface/PHGCSimAccumulator.h:53:5: warning: definition of implicit copy assignment operator for 'SimHitCollection' is deprecated because it has a user-declared copy constructor [-Wdeprecated-copy]

PR validation:

Bot tests.

@iarspider
Copy link
Contributor Author

please test for CMSSW_14_1_CLANG_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44602/39784

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • DataFormats/HGCalDigi (upgrade, simulation)

@mdhildreth, @civanch, @subirsarkar, @srimanob can you please review it and eventually sign? Thanks.
@rovere, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-359b8e/38577/summary.html
COMMIT: 73ad3bd
CMSSW: CMSSW_14_1_CLANG_X_2024-04-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44602/38577/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-359b8e/38577/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-359b8e/38577/git-merge-result

Comparison Summary

Summary:

  • You potentially added 11560 lines to the logs
  • Reco comparison results: 31956 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3304819
  • DQMHistoTests: Total failures: 54814
  • DQMHistoTests: Total nulls: 181
  • DQMHistoTests: Total successes: 3249804
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 141.042,... ): 0.004 KiB JetMET/SUSYDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@civanch
Copy link
Contributor

civanch commented Apr 4, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-359b8e/38608/summary.html
COMMIT: 73ad3bd
CMSSW: CMSSW_14_1_X_2024-04-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44602/38608/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 98 lines to the logs
  • Reco comparison results: 44 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3307717
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3307697
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Apr 5, 2024

+1

1 similar comment
@civanch
Copy link
Contributor

civanch commented Apr 7, 2024

+1

@srimanob
Copy link
Contributor

srimanob commented Apr 7, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants