Do not include EventSetup record definitions in device code #44682

iarspider · 2024-04-10T07:04:23Z

PR description:

PR validation:

Bot tests. Compilation is expected to fail, but errors about missing intrinsics when compiling PFClusterSoAProducerKernel.dev.cc and PFRecHitProducerKernel.dev.cc should be gone.

iarspider · 2024-04-10T07:04:39Z

please test for el9_amd64_gcc13

cmsbuild · 2024-04-10T07:04:46Z

cms-bot internal usage

cmsbuild · 2024-04-10T07:11:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44682/39880

This PR adds an extra 16KB to repository

cmsbuild · 2024-04-10T07:12:05Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

RecoParticleFlow/PFRecHitProducer (reconstruction)

@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@hatakeyamak, @mmarionncern, @lgray, @missirol, @seemasharmafnal this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-04-10T07:52:06Z

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-992de0/38727/summary.html
COMMIT: 7e5ff42
CMSSW: CMSSW_14_1_X_2024-04-05-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44682/38727/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-992de0/38727/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-992de0/38727/git-merge-result

Build

I found compilation error when building:

Copying tmp/el9_amd64_gcc13/src/HeterogeneousTest/AlpakaWrapper/src/alpaka/HeterogeneousTestAlpakaWrapperCudaAsync/libHeterogeneousTestAlpakaWrapperCudaAsync_nv.a to productstore area:
Copying tmp/el9_amd64_gcc13/src/HeterogeneousTest/AlpakaWrapper/src/alpaka/HeterogeneousTestAlpakaWrapperROCmAsync/libHeterogeneousTestAlpakaWrapperROCmAsync_rocm.a to productstore area:
Copying tmp/el9_amd64_gcc13/src/RecoParticleFlow/PFRecHitProducer/plugins/RecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync/libRecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el9_amd64_gcc13/src/RecoParticleFlow/PFRecHitProducer/plugins/RecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync/libRecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el9_amd64_gcc13/src/RecoParticleFlow/PFRecHitProducer/plugins/RecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync/libRecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1838: tmp/el9_amd64_gcc13/src/RecoParticleFlow/PFRecHitProducer/plugins/RecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync/libRecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync_rocm.a] Error 1
Copying tmp/el9_amd64_gcc13/src/RecoParticleFlow/PFClusterProducer/plugins/RecoParticleFlowPFClusterProducersPluginsPortableROCmAsync/libRecoParticleFlowPFClusterProducersPluginsPortableROCmAsync_rocm.a to productstore area:
@@@@ Checking for missing symbols was SKIPPED due to NO_LIB_CHECKING flag in BuildFile: libUtilitiesStaticAnalyzers.so
Copying tmp/el9_amd64_gcc13/src/RecoLocalTracker/SiPixelClusterizer/plugins/RecoLocalTrackerSiPixelClusterizerPluginsPortableROCmAsync/libRecoLocalTrackerSiPixelClusterizerPluginsPortableROCmAsync_rocm.a to productstore area:
Copying tmp/el9_amd64_gcc13/src/RecoTracker/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableROCmAsync/libRecoPixelVertexingPixelVertexFindingPluginsPortableROCmAsync_rocm.a to productstore area:
Copying tmp/el9_amd64_gcc13/src/RecoTracker/PixelVertexFinding/test/deviceVertexFinderByDensity_tROCmAsync/libdeviceVertexFinderByDensity_tROCmAsync_rocm.a to productstore area:

RecoParticleFlow/PFRecHitProducer/plugins/alpaka/CalorimeterDefinitions.h

cmsbuild · 2024-04-10T08:06:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44682/39881

This PR adds an extra 12KB to repository

cmsbuild · 2024-04-10T08:06:27Z

Pull request #44682 was updated. @mandrenguyen, @jfernan2, @cmsbuild can you please check and sign again.

iarspider · 2024-04-10T10:44:06Z

please test for el9_amd64_gcc13

cmsbuild · 2024-04-25T07:03:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44682/40096

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/TrackSoA/interface/TrackDefinitions.h modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
- File RecoParticleFlow/PFRecHitProducer/plugins/alpaka/CalorimeterDefinitions.h modified in PR(s): Do not include EventSetup record definitions in device code #44828
- File RecoParticleFlow/PFRecHitProducer/plugins/alpaka/PFRecHitSoAProducer.cc modified in PR(s): Do not include EventSetup record definitions in device code #44828
- File RecoParticleFlow/PFRecHitProducer/plugins/alpaka/PFRecHitTopologyESProducer.cc modified in PR(s): Do not include EventSetup record definitions in device code #44828

cmsbuild · 2024-04-25T07:04:04Z

Pull request #44682 was updated. @makortel, @mandrenguyen, @cmsbuild, @fwyzard, @jfernan2 can you please check and sign again.

fwyzard · 2024-04-25T07:50:34Z

+heterogeneous

jfernan2 · 2024-04-25T08:27:37Z

+1

cmsbuild · 2024-04-25T08:27:59Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2024-04-26T02:19:51Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-992de0/39088/summary.html
COMMIT: a9b6640
CMSSW: CMSSW_14_1_X_2024-04-19-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44682/39088/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 12262 lines to the logs
Reco comparison results: 60020 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3425959
DQMHistoTests: Total failures: 195438
DQMHistoTests: Total nulls: 250
DQMHistoTests: Total successes: 3230251
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.0279999999999996 KiB( 48 files compared)
DQMHistoSizes: changed ( 10224.0 ): 1.019 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): 1.412 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 141.042 ): -0.020 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 141.044 ): 0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 250202.181 ): 0.006 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.469 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -1.600 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 8.0 ): -0.262 KiB SiStrip/MechanicalView
Checked 206 log files, 170 edm output root files, 49 DQM output files

antoniovilela · 2024-04-29T01:51:46Z

please test for el8_amd64_gcc12

cmsbuild · 2024-04-29T08:02:59Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-992de0/39134/summary.html
COMMIT: a9b6640
CMSSW: CMSSW_14_1_X_2024-04-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44682/39134/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 4 lines from the logs
Reco comparison results: 47 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3433373
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3433353
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 206 log files, 170 edm output root files, 49 DQM output files
TriggerResults: no differences found

antoniovilela · 2024-04-29T16:06:06Z

+1

cmsbuild added this to the CMSSW_14_1_X milestone Apr 10, 2024

cmsbuild added reconstruction-pending pending-signatures orp-pending tests-started code-checks-pending labels Apr 10, 2024

iarspider mentioned this pull request Apr 10, 2024

[Do not merge] Test all gcc13 changes together #44632

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 10, 2024

cmsbuild added tests-rejected and removed tests-started labels Apr 10, 2024

fwyzard reviewed Apr 10, 2024

View reviewed changes

RecoParticleFlow/PFRecHitProducer/plugins/alpaka/CalorimeterDefinitions.h Show resolved Hide resolved

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Apr 10, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 10, 2024

iarspider force-pushed the missing-intrinsics-3 branch from 06bc24c to 09fdcb0 Compare April 10, 2024 10:42

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 10, 2024

iarspider force-pushed the missing-intrinsics-3 branch from 09fdcb0 to f8f72dd Compare April 10, 2024 10:43

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 25, 2024

cmsbuild added tests-started heterogeneous-approved and removed tests-pending heterogeneous-pending labels Apr 25, 2024

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Apr 25, 2024

cmsbuild added tests-approved and removed tests-started labels Apr 26, 2024

cmsbuild added tests-started and removed tests-approved labels Apr 29, 2024

cmsbuild added tests-approved and removed tests-started labels Apr 29, 2024

cmsbuild added orp-approved and removed orp-pending labels Apr 29, 2024

cmsbuild merged commit 6a03776 into cms-sw:master Apr 29, 2024
18 checks passed

fwyzard mentioned this pull request Apr 29, 2024

Do not include EventSetup record definitions in device code [14.0.x] #44871

Merged

cmsbuild mentioned this pull request Apr 30, 2024

Reorder include statements #44870

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not include EventSetup record definitions in device code #44682

Do not include EventSetup record definitions in device code #44682

iarspider commented Apr 10, 2024

iarspider commented Apr 10, 2024

cmsbuild commented Apr 10, 2024 •

edited

Loading

cmsbuild commented Apr 10, 2024

cmsbuild commented Apr 10, 2024

cmsbuild commented Apr 10, 2024

cmsbuild commented Apr 10, 2024

cmsbuild commented Apr 10, 2024

iarspider commented Apr 10, 2024

cmsbuild commented Apr 25, 2024

cmsbuild commented Apr 25, 2024

fwyzard commented Apr 25, 2024

jfernan2 commented Apr 25, 2024

cmsbuild commented Apr 25, 2024

cmsbuild commented Apr 26, 2024

antoniovilela commented Apr 29, 2024

cmsbuild commented Apr 29, 2024

antoniovilela commented Apr 29, 2024

Do not include EventSetup record definitions in device code #44682

Do not include EventSetup record definitions in device code #44682

Conversation

iarspider commented Apr 10, 2024

PR description:

PR validation:

iarspider commented Apr 10, 2024

cmsbuild commented Apr 10, 2024 • edited Loading

cmsbuild commented Apr 10, 2024

cmsbuild commented Apr 10, 2024

cmsbuild commented Apr 10, 2024

Build

cmsbuild commented Apr 10, 2024

cmsbuild commented Apr 10, 2024

iarspider commented Apr 10, 2024

cmsbuild commented Apr 25, 2024

cmsbuild commented Apr 25, 2024

fwyzard commented Apr 25, 2024

jfernan2 commented Apr 25, 2024

cmsbuild commented Apr 25, 2024

cmsbuild commented Apr 26, 2024

Comparison Summary

antoniovilela commented Apr 29, 2024

cmsbuild commented Apr 29, 2024

Comparison Summary

antoniovilela commented Apr 29, 2024

cmsbuild commented Apr 10, 2024 •

edited

Loading