-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(example): improve example app types (1st iteration) #734
Conversation
🦋 Changeset detectedLatest commit: a5166aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave it as comment. Great job! we are really getting closer with TS here.
Still few ts-ingores was added do you plan to take them down in separate PR? if yes leave it as it is
Thank You so much, @barsukov for the thorough review and comments. 💙 I addressed the ones I could for now. For the rest, we had no types and many errors, so this PR is the first iteration improving many files (mentioned in description). However, it's A LOT to understand and type at once... so I decided to get in what I have so far, double check types in That sound okay? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Improved example app types (1st iteration).
Changes Made
MonorepoChecker
Related Issues
Checklist