Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(example): improve example app types (1st iteration) #734

Merged
merged 11 commits into from
Jan 31, 2025

Conversation

guoda-puidokaite
Copy link
Contributor

@guoda-puidokaite guoda-puidokaite commented Jan 22, 2025

Summary

Improved example app types (1st iteration).

Changes Made

  • Converted all example app components to TS syntax and improved types.
  • The errors (and therefore ignore statements) have been fixed for many files.
  • However, some files have been improved but issues still remain e.g. due to package type and other issues.
  • Committing this PR as the first "type improvement" iteration, to not overwhelm with more files.
  • Note: Deleted MonorepoChecker

Related Issues

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: a5166aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-app-example Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 22, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-01-31 12:04 UTC

@guoda-puidokaite guoda-puidokaite added ui-components All tasks related to juno-ui-components library package All tasks related to package under packages/ labels Jan 23, 2025
@guoda-puidokaite guoda-puidokaite changed the title chore(ui): convert components to typescript syntax chore(ui): improve example app types Jan 27, 2025
@guoda-puidokaite guoda-puidokaite changed the title chore(ui): improve example app types chore(example): improve example app types Jan 27, 2025
@guoda-puidokaite guoda-puidokaite marked this pull request as ready for review January 27, 2025 14:08
@guoda-puidokaite guoda-puidokaite requested a review from a team as a code owner January 27, 2025 14:08
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave it as comment. Great job! we are really getting closer with TS here.
Still few ts-ingores was added do you plan to take them down in separate PR? if yes leave it as it is

apps/example/src/App.tsx Show resolved Hide resolved
apps/example/src/components/StoreProvider.tsx Show resolved Hide resolved
apps/example/src/components/StoreProvider.tsx Outdated Show resolved Hide resolved
apps/example/src/components/auth/HeaderUser.tsx Outdated Show resolved Hide resolved
apps/example/src/mocks/browser.ts Show resolved Hide resolved
apps/example/src/mocks/browser.ts Show resolved Hide resolved
apps/example/src/mocks/browser.ts Outdated Show resolved Hide resolved
apps/example/src/lib/store/index.ts Show resolved Hide resolved
@guoda-puidokaite
Copy link
Contributor Author

guoda-puidokaite commented Jan 28, 2025

I leave it as comment. Great job! we are really getting closer with TS here. Still few ts-ingores was added do you plan to take them down in separate PR? if yes leave it as it is

Thank You so much, @barsukov for the thorough review and comments. 💙 I addressed the ones I could for now.

For the rest, we had no types and many errors, so this PR is the first iteration improving many files (mentioned in description).

However, it's A LOT to understand and type at once... so I decided to get in what I have so far, double check types in ui-components and then look at the remainder based on that, with fresh eyes. Many more file changes will be required.

That sound okay?

@guoda-puidokaite guoda-puidokaite changed the title chore(example): improve example app types chore(example): improve example app types (1st iteration) Jan 28, 2025
barsukov
barsukov previously approved these changes Jan 29, 2025
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job

@guoda-puidokaite guoda-puidokaite removed the package All tasks related to package under packages/ label Jan 30, 2025
@guoda-puidokaite guoda-puidokaite added app Any app that is not specific label that lives under apps/ and removed ui-components All tasks related to juno-ui-components library labels Jan 30, 2025
Copy link
Contributor

@taymoor89 taymoor89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guoda-puidokaite guoda-puidokaite merged commit 74fb4ad into main Jan 31, 2025
15 checks passed
@guoda-puidokaite guoda-puidokaite deleted the guoda-example-app-types branch January 31, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Any app that is not specific label that lives under apps/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants