Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task](exampleapp): Migrate Example App to TypeScript Using ts-migrate tool #593

Open
3 of 4 tasks
Tracked by #541
edda opened this issue Nov 6, 2024 · 1 comment
Open
3 of 4 tasks
Tracked by #541
Assignees

Comments

@edda
Copy link
Contributor

edda commented Nov 6, 2024

Description

Migrate the example application from JavaScript to TypeScript using the airbnb ts-migrate tool. Document any insights on the tool's effectiveness, including challenges, limitations, and helpful tips for usage.

Acceptance Criteria

  • Migrate the codebase of the example app from JavaScript to TypeScript.
  • Use ts-migrate as the primary tool for the migration.
  • Document findings on:
    • Benefits and shortcomings of ts-migrate
    • Usability tips and best practices for others performing similar migrations
  • Add any additional observations that may assist with future migrations.

Notes

  • Include your documentation in our team docu
  • Consider any edge cases or manual adjustments needed during the migration process.

Resources

@edda edda changed the title Migrate example app to TypeScript using ts-migrate tool. If the tool proves helpful in migrating apps from JS to TS, write down findings, shortcomings, usage tips, etc. [Task](exampleapp): Migrate Example App to TypeScript Using ts-migrate Nov 6, 2024
@edda edda changed the title [Task](exampleapp): Migrate Example App to TypeScript Using ts-migrate [Task](exampleapp): Migrate Example App to TypeScript Using ts-migrate tool Nov 6, 2024
@edda edda added this to the TypeScript Migration of Juno Core milestone Nov 6, 2024
@guoda-puidokaite
Copy link
Contributor

guoda-puidokaite commented Jan 13, 2025

Update (13th Jan, 2025)

  • Example app has been migrated from JavaScript to TypeScript with PR (chore(ui): migrate example app to ts #696).
  • Type issues have been silenced for now, until ui-components are revisited (in tickets below).
  • ts-migrate tool:
    • Was mostly helpful to rename files automatically and change components to Typescript signature.
      • Note: Since the tool automatically migrated all files, we need to make sure to keep ones in the public folder as js.
    • Only added type any. Correct typing needs to be done by the developer.
    • Introduced many error ignore lines that polluted the code for issues that didn't exist. Our ts configuration wasn't picked up (there's most likely a solution). I removed these and silenced or resolved any type issues that existed manually.

Update (27th Jan, 2025)

Next:

  • Will go through the example app and remove unnecessary experimental files.
  • Then, will continue migrating example app with this ticket, adding correct types and resolving the remaining silenced issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants