Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copyonwrite/367/fix make error mockery #368

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Copyonwrite/367/fix make error mockery #368

merged 3 commits into from
Nov 12, 2024

Conversation

copyonwrite
Copy link
Collaborator

Description

Bugfix for Makefile error (mockery not found)

#367

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes 367

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@MR2011 MR2011 merged commit 9b6acd4 into main Nov 12, 2024
7 checks passed
@MR2011 MR2011 deleted the copyonwrite/367/fix-make-error-mockery branch November 12, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MR2011 MR2011 MR2011 approved these changes

@drochow drochow Awaiting requested review from drochow drochow is a code owner

@dorneanu dorneanu Awaiting requested review from dorneanu dorneanu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@copyonwrite @MR2011