Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(doc): Updated Product Design Document #338

Merged
merged 3 commits into from
Oct 29, 2024
Merged

chore(doc): Updated Product Design Document #338

merged 3 commits into from
Oct 29, 2024

Conversation

lolaapenna
Copy link
Collaborator

Description

Updated the document using concise terms; also added personas, high-level features, and high-level architecture diagram.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

drochow
drochow approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@drochow drochow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dorneanu
dorneanu approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@dorneanu dorneanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@drochow drochow merged commit 85ac90d into main Oct 29, 2024
7 checks passed
@drochow drochow deleted the lolaapenna/issue_255/update-PRD branch October 29, 2024 13:52
dustindemmerle pushed a commit that referenced this pull request Nov 6, 2024
@lolaapenna @dustindemmerle
chore(doc): Updated Product Design Document (#338)
074f98f 
* doc(PDD):Updating the product design document

* chore(doc): added personas and high-level features

* chore(doc):added image links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drochow drochow drochow approved these changes

@dorneanu dorneanu dorneanu approved these changes

@MR2011 MR2011 Awaiting requested review from MR2011 MR2011 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lolaapenna @dorneanu @drochow