Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue): refactor issue aggregations #296

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

MR2011
Copy link
Collaborator

@MR2011 MR2011 commented Oct 17, 2024

Description

This PR refactors the aggreation query for Issues by utilizing CTE feature in MariaDB. Additionally, the componentInstanceCount is now showing the correct value.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

drochow
drochow previously approved these changes Oct 18, 2024
Copy link
Collaborator

@drochow drochow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

I'd suggest we create a ticket for a more comprehensive test, though. We are actually based on this test, but I'm not 100% sure if it correctly counts things. Am I missing something?

dorneanu
dorneanu previously approved these changes Oct 18, 2024
Copy link
Collaborator

@dorneanu dorneanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MR2011 MR2011 dismissed stale reviews from dorneanu and drochow via 1fd0e84 October 21, 2024 12:18
@drochow drochow merged commit f423cf9 into main Oct 22, 2024
7 checks passed
@drochow drochow deleted the mr2011/issue_278/refactor_issue_aggregations branch October 22, 2024 08:07
dustindemmerle pushed a commit that referenced this pull request Oct 23, 2024
* feat(issue): refactor issue aggregations

* feat(issue): add e2e test for aggregation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants