fix: fetch sub-manifests from keppel #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorneanu
reviewed
Oct 8, 2024
dorneanu
reviewed
Oct 8, 2024
MR2011
reviewed
Oct 8, 2024
| "repository": repository.Name, | ||
| }).WithError(err).Error("Error during ListManifestsOfManifest") | ||
| } | ||
|
|
||
| componentVersion, err := keppelProcessor.ProcessManifest(manifest, component.Id) | ||
| if err != nil { |
There was a problem hiding this comment.
why not if err != nil || componentVersion == nil ?
dorneanu
approved these changes
Oct 8, 2024
MR2011
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keppel does not scan in all cases the top layer of an image. The primary cause of that is multi-arch images. In such cases we need to list all manifests of the manifest and check for vulnerabilities on those.
In perspective, we need to decide if that is as well stored in different versions that are related to each other instead.
What type of PR is this? (check all applicable)
Related Tickets & Documents
#247
Added tests?
Added to documentation?
Checklist