feat(services): add aggregations #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drochow
reviewed
Oct 1, 2024
drochow
requested changes
Oct 2, 2024
Comment on lines
439
to
493
| When("Getting Services with Aggregations", Label("GetServicesWithAggregations"), func() { | ||
| BeforeEach(func() { | ||
| _ = seeder.SeedDbWithNFakeData(10) | ||
| }) | ||
| Context("and and we have 10 elements in the database", func() { | ||
| It("returns the services with componentInstance count", func() { | ||
| entriesWithAggregations, err := db.GetServicesWithComponentInstanceCount(nil) | ||
|
|
||
| By("throwing no error", func() { | ||
| Expect(err).To(BeNil()) | ||
| }) | ||
|
|
||
| By("returning some aggregations", func() { | ||
| for _, entryWithAggregations := range entriesWithAggregations { | ||
| Expect(entryWithAggregations).NotTo( | ||
| BeEquivalentTo(entity.ServiceAggregations{})) | ||
| } | ||
| }) | ||
| }) | ||
| It("returns correct aggregation values", func() { | ||
| //Should be filled with a check for each aggregation value, | ||
| // this is currently skipped due to the complexity of the test implementation | ||
| // as we would need to implement for each of the aggregations a manual aggregation | ||
| // based on the seederCollection. | ||
| // | ||
| // This tests should therefore only get implemented in case we encourage errors in this area to test against | ||
| // possible regressions | ||
| }) | ||
| }) | ||
| Context("and and we have 10 elements in the database", func() { | ||
| It("returns the services with issueMatch count", func() { | ||
| entriesWithAggregations, err := db.GetServicesWithIssueMatchCount(nil) | ||
|
|
||
| By("throwing no error", func() { | ||
| Expect(err).To(BeNil()) | ||
| }) | ||
|
|
||
| By("returning some aggregations", func() { | ||
| for _, entryWithAggregations := range entriesWithAggregations { | ||
| Expect(entryWithAggregations).NotTo( | ||
| BeEquivalentTo(entity.ServiceAggregations{})) | ||
| } | ||
| }) | ||
| }) | ||
| It("returns correct aggregation values", func() { | ||
| //Should be filled with a check for each aggregation value, | ||
| // this is currently skipped due to the complexity of the test implementation | ||
| // as we would need to implement for each of the aggregations a manual aggregation | ||
| // based on the seederCollection. | ||
| // | ||
| // This tests should therefore only get implemented in case we encourage errors in this area to test against | ||
| // possible regressions | ||
| }) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Don't we need a test then here that is checking that for 0 counts the service is still listed?
So I'm expecting 10 services even though they might not all have a count > 0.
drochow
requested changes
Oct 8, 2024
|
@MR2011 Am I missing something? I think its just about calling: seeder.SeedServices(10)in a test and check then if also the 0 count services are returned (if no filter is applied) |
|
drochow
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following two aggregations for services:
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Tests:
Added to documentation?
Checklist