Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streaming Trace, Part 2: simplify PipelineTracer to remove parentTracer #2925

Open
wants to merge 28 commits into
base: jsnell/stream-trace-workers-part-1
Choose a base branch
from
Open

Streaming Trace, Part 2: simplify PipelineTracer to remove parentTracer #2925

wants to merge 28 commits into from

Commits on Oct 16, 2024

  1. Start restructuring the io/trace.h to prepare for streaming trace

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    fd3a1b9 View commit details
    Browse the repository at this point in the history

  2. Collect trace onset metadata into a separate struct

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4be33dc View commit details
    Browse the repository at this point in the history

  3. Move FetchEventInfo to trace-common w/ minor cleanups

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c77720d View commit details
    Browse the repository at this point in the history

  4. Move several trace info structs to trace-common.h

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0bff873 View commit details
    Browse the repository at this point in the history

  5. Move more trace info structs to trace-common.h

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    df350c8 View commit details
    Browse the repository at this point in the history

  6. Move trace event type definitions o trace-common.h

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    bb257f2 View commit details
    Browse the repository at this point in the history

  7. Move Trace impl to trace-legacy.c++

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    14913a6 View commit details
    Browse the repository at this point in the history

  8. Additional minor cleanups

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    02bf2fe View commit details
    Browse the repository at this point in the history

  9. Consolidate outcome setters to a single setOutcomeInfo

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    400dee8 View commit details
    Browse the repository at this point in the history

  10. Move more legacy in-memory trace code to trace-legacy.{c++,h}.

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3c1540b View commit details
    Browse the repository at this point in the history

  11. Use trace: namespace directly for common types

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6a240e2 View commit details
    Browse the repository at this point in the history

  12. Add initial scaffolding for new StreamingTrace class

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a9881e9 View commit details
    Browse the repository at this point in the history

  13. Remove deprecated trace-legacy.h aliases

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5e76630 View commit details
    Browse the repository at this point in the history

  14. More implementation detail for streaming trace

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e941745 View commit details
    Browse the repository at this point in the history

  15. Initial tail worker support in workerd 

    Adds the ability for a workerd worker configuration to specify
a tail worker configuration. This is useful for testing tail
worker development locally, which up to now has not been possible.
    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    24503ba View commit details
    Browse the repository at this point in the history

  16. Add streaming tail workers autogate

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c687e6b View commit details
    Browse the repository at this point in the history

  17. More cleanups and refinements on revised trace api

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    acc4439 View commit details
    Browse the repository at this point in the history

  18. Additional fixuups after resolving merge conflicts

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    cd8f4d8 View commit details
    Browse the repository at this point in the history

  19. Fixup comment position in capnp

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    939c8ab View commit details
    Browse the repository at this point in the history

  20. Remove accountId and stableId from the schema

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0c590f4 View commit details
    Browse the repository at this point in the history

  21. s/gate open/gate closed

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    38ef60b View commit details
    Browse the repository at this point in the history

  22. Limit streaming trace metrics struct to float

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b0a3df6 View commit details
    Browse the repository at this point in the history

  23. Remove the unit field in Metric struct

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5a1bcb1 View commit details
    Browse the repository at this point in the history

  24. Updates based on feedback 

    * Collapse Info events into the Onset
* Remove ActorFlushInfo
* Other cleanups
    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    cc46604 View commit details
    Browse the repository at this point in the history

  25. Remove unnecessary kj::Date argument

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3d7994a View commit details
    Browse the repository at this point in the history

  26. Remove the transactional flag for trace spans 

    No need to express it explicitly. Can be inferred if necessary
based on span outcome.
    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    fb23d06 View commit details
    Browse the repository at this point in the history

  27. Flatten the StreamEvent structure more

    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    219cd0b View commit details
    Browse the repository at this point in the history

  28. Simplify PipelineTracer 

    Remove the PipelineTracer parent tracer. The onComplete promise
can be used to track the completion of the pipeline to report
to the parent instead. The parent tracer is not used in workerd
at all.
    @jasnell
    jasnell committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d9ff07e View commit details
    Browse the repository at this point in the history