Streaming Trace, Part 2: simplify PipelineTracer to remove parentTracer #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
changed the title
jasnell
force-pushed
the
jsnell/stream-trace-workers-part-1
branch
from
8b93a32
to
0860b64
Compare
jasnell
force-pushed
the
jsnell/stream-trace-workers-part-2
branch
from
7fa71b9
to
c792f66
Compare
jasnell
force-pushed
the
jsnell/stream-trace-workers-part-1
branch
from
0860b64
to
aa9c7b6
Compare
Adds the ability for a workerd worker configuration to specify a tail worker configuration. This is useful for testing tail worker development locally, which up to now has not been possible.
* Collapse Info events into the Onset * Remove ActorFlushInfo * Other cleanups
jasnell
force-pushed
the
jsnell/stream-trace-workers-part-1
branch
from
b8c312d
to
3d7994a
Compare
jasnell
force-pushed
the
jsnell/stream-trace-workers-part-2
branch
from
c792f66
to
05de79d
Compare
anonrig
reviewed
Oct 16, 2024
|
|
||
| // We'll create a WorkerTracer if, and only if, there are tail workers configured. | ||
| auto maybeWorkerTracer = ([&]() -> kj::Maybe<kj::Own<WorkerTracer>> { | ||
| if (loggingServices.size() > 0) { |
There was a problem hiding this comment.
Can we handle the negative case first and simplify the indentation
jasnell
force-pushed
the
jsnell/stream-trace-workers-part-2
branch
from
05de79d
to
7c4d2ae
Compare
No need to express it explicitly. Can be inferred if necessary based on span outcome.
jasnell
force-pushed
the
jsnell/stream-trace-workers-part-1
branch
from
1412c58
to
fb23d06
Compare
jasnell
force-pushed
the
jsnell/stream-trace-workers-part-2
branch
from
7c4d2ae
to
da69a9d
Compare
Remove the PipelineTracer parent tracer. The onComplete promise can be used to track the completion of the pipeline to report to the parent instead. The parent tracer is not used in workerd at all.
jasnell
force-pushed
the
jsnell/stream-trace-workers-part-2
branch
from
da69a9d
to
d9ff07e
Compare
jasnell
force-pushed
the
jsnell/stream-trace-workers-part-1
branch
2 times, most recently
from
463db3b
to
af4a3ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the PipelineTracer parent tracer. The onComplete promise can be used to track the completion of the pipeline to report to the parent instead. The parent tracer is not used in workerd at all.
Builds on #2852