-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update git hook tests #89
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…checking whether core hooks path is overridden by repos
JasonTheMain
previously approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes
markdboyd
commented
May 23, 2024
markdboyd
commented
May 23, 2024
thanks for cleaning up the README, too! |
wz-gsa
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything appears to be good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Addresses #37
As noted in #37, it is possible to have local git hooks and gitleaks co-exist, but the tests run by
make audit
assume that is not possible. To fix this behavior, this PR:make audit
if a repo has a custom.git/hooks/pre-commit
hook, since this scenario does not actually prevent gitleaks from runningcore.hooksPath
is not overridden at the repo level, which would prevent gitleaks from runningOther unrelated fixes in the PR include:
security considerations
This PR should be correcting a misunderstanding of how git hooks work but not actually introducing any chance that the global git hook for gitleaks won't run. However, the changes should be audited carefully to avoid any possible regression