Fix check for overridden hooks path #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Follow-up to #89
We discovered that for repos which were overriding
core.hooksPath, such as those using tools like husky,gitleakswas not running. And the test inmake auditthat should catch whencore.hooksPathis overridden was not failing on these repos.This PR fixes the check to correctly detect when
core.hooksPathis overridden and fails appropriately. The PR also adds a CI test to ensure that this behavior works as expected.security considerations
This PR improves security by ensuring that
make auditforgitleakswill fail on any repo wherecore.hooksPathis overridden, which in turn preventsgitleaksfrom running. Themake auditfailure should in turn force the repo owners to remove the override forcore.hooksPath.