Test suite: fix topEntity inclusion Ram/RMultiTop #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of `testBench` testing `topEntity`, the former included a functionally indentical copy of the latter. Fixes #2192
christiaanb
reviewed
May 18, 2022
Comment on lines
+5
to
+7
|
|
||
| {-# OPTIONS_GHC -Wno-orphans #-} | ||
|
|
There was a problem hiding this comment.
Depends on your definition of "needed". I like to compile HDL with -Wall and not have any warnings, and then it's needed, since we use createDomain below.
So instead of "this shouldn't be needed", I'd like to counter "we should change CI so this actually is needed" 😆
(I'm not actually suggesting we do that now)
alex-mckenna
pushed a commit
that referenced
this pull request
Jun 14, 2022
Instead of `testBench` testing `topEntity`, the former included a functionally indentical copy of the latter. Fixes #2192 (cherry picked from commit 4174d58) Co-authored-by: Peter Lebbing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
testBenchtestingtopEntity, the former included afunctionally indentical copy of the latter.
Fixes #2192
Still TODO:
Write a changelog entry (see changelog/README.md)