Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat type dependencies as production dependencies #1058

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

filipsobol
Copy link
Member

@filipsobol filipsobol commented Jan 17, 2025

Suggested merge commit message (convention)

Internal: Update eslint-config-ckeditor5 to ^9.0.0.

Feature (dependency-checker): Treat type dependencies as production dependencies. Related to ckeditor/ckeditor5#17213.

MINOR BREAKING CHANGE (dependency-checker): Treat type dependencies as production dependencies.

@coveralls
Copy link

Coverage Status

coverage: 88.001%. remained the same
when pulling 71e5569 on types-as-production-dependencies
into d955364 on master.

Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

The package name in the suggested merge commit message should be without the dev- prefix:

Feature (dependency-checker): ...

MINOR BREAKING CHANGE (dependency-checker): ...

@filipsobol filipsobol merged commit 3972798 into master Jan 20, 2025
7 checks passed
@filipsobol filipsobol deleted the types-as-production-dependencies branch January 20, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants