Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat type dependencies as production dependencies #1054

Closed
wants to merge 13 commits into from

Conversation

filipsobol
Copy link
Member

@filipsobol filipsobol commented Jan 8, 2025

Suggested merge commit message (convention)

Internal: Update eslint-config-ckeditor5 to ^9.0.0.

Feature (dev-dependency-checker): Treat type dependencies as production dependencies. Related to ckeditor/ckeditor5#17213.

MINOR BREAKING CHANGE (dev-dependency-checker): Treat type dependencies as production dependencies.


Additional information

⚠️ Merge with squash ⚠️

@filipsobol filipsobol requested a review from psmyrek January 17, 2025 13:03
Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@filipsobol filipsobol force-pushed the use-oxc-parser-in-dep-checker branch from 74b0065 to 80ca9c3 Compare January 17, 2025 14:52
@filipsobol
Copy link
Member Author

Continued in #1058.

@filipsobol filipsobol closed this Jan 17, 2025
@filipsobol filipsobol deleted the use-oxc-parser-in-dep-checker branch January 17, 2025 14:55
@coveralls
Copy link

Coverage Status

coverage: 88.001%. remained the same
when pulling 80ca9c3 on use-oxc-parser-in-dep-checker
into d955364 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants