-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat type dependencies as production dependencies #1054
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psmyrek
reviewed
Jan 17, 2025
packages/ckeditor5-dev-dependency-checker/lib/checkdependencies.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-dev-dependency-checker/lib/checkdependencies.js
Outdated
Show resolved
Hide resolved
psmyrek
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
filipsobol
force-pushed
the
use-oxc-parser-in-dep-checker
branch
from
January 17, 2025 14:52
74b0065
to
80ca9c3
Compare
Continued in #1058. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Update
eslint-config-ckeditor5
to^9.0.0
.Feature (dev-dependency-checker): Treat type dependencies as production dependencies. Related to ckeditor/ckeditor5#17213.
MINOR BREAKING CHANGE (dev-dependency-checker): Treat type dependencies as production dependencies.
Additional information